Closed
Bug 283547
Opened 19 years ago
Closed 19 years ago
OOM crash [@ nsGopherDirListingConv::OnDataAvailable]
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: ajschult784)
References
()
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
|
3.22 KB,
patch
|
Biesinger
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
allocations need to be checked and the proper deallocators should be used
|
Assignee | |
Comment 1•19 years ago
|
||
Assignee: darin → ajschult
Status: NEW → ASSIGNED
Attachment #175696 -
Flags: superreview?(darin)
Attachment #175696 -
Flags: review?(cbiesinger)
|
||
Updated•19 years ago
|
Attachment #175696 -
Flags: superreview?(darin) → superreview+
|
||
Comment 2•19 years ago
|
||
Comment on attachment 175696 [details] [diff] [review] check allocations, free them properly I'm not sure that DigestBufferLines is doing error handling correctly, but at least this should prevent the crash. (I'd think that ideally, ODA would cancel the channel with NS_ERROR_OUT_OF_MEMORY in this case)
Attachment #175696 -
Flags: review?(cbiesinger) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Crash Signature: [@ nsGopherDirListingConv::OnDataAvailable]
You need to log in
before you can comment on or make changes to this bug.
Description
•