Closed Bug 283659 Opened 19 years ago Closed 19 years ago

punycode.c:130: warning: signed and unsigned type in conditional expression

Categories

(Core :: Networking, defect)

x86
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: bastiaan, Assigned: darin.moz)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050225
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050225

/home/baafie/mozilla/netwerk/dns/src/punycode.c: In function `punycode_encode':
/home/baafie/mozilla/netwerk/dns/src/punycode.c:130: warning: signed and
unsigned type in conditional expression

This is a potential assignment of an unsigned char to a signed char.

Reproducible: Always

Steps to Reproduce:
Attached patch Add castSplinter Review
Attachment #175568 - Flags: superreview+
Attachment #175568 - Flags: review+
Comment on attachment 175568 [details] [diff] [review]
Add cast

I suppose I screwed up the review flags
Attachment #175568 - Flags: superreview-
Attachment #175568 - Flags: superreview+
Attachment #175568 - Flags: review-
Attachment #175568 - Flags: review+
Comment on attachment 175568 [details] [diff] [review]
Add cast

fixing review flags
Attachment #175568 - Flags: superreview?(darin)
Attachment #175568 - Flags: superreview-
Attachment #175568 - Flags: review?(darin)
Attachment #175568 - Flags: review-
Attachment #175568 - Flags: superreview?(darin)
Attachment #175568 - Flags: superreview+
Attachment #175568 - Flags: review?(darin)
Attachment #175568 - Flags: review+
fixed-on-trunk
Status: UNCONFIRMED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: