285285 - Add SINGLE_LINE state to single line text inputbox

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Louie Zhao]

The single line text inputbox should have SINGLE_LINE state, which is an extened
state.

Comment 1

[Louie Zhao]

Attachment: patch v1

Comment 2

[Aaron Leventhal]

Attachment: Intermediate patch for Louie. Not for review.

Comment 3

[Aaron Leventhal]

Attachment: Another patch for Louie

Comment 4

[Aaron Leventhal]

Comment on attachment 176726 [details] [diff] [review]
patch v1

Talked with Louie about a better fix.

Comment 5

[Aaron Leventhal]

Attachment: Clean up form control and text field state code, add single line extended state support

Comment 6

[Philip K. Warren]

Comment on attachment 176741 [details] [diff] [review]
Clean up form control and text field state code, add single line extended state support

>Index: accessible/src/html/nsHTMLFormControlAccessible.cpp
>@@ -26,28 +26,29 @@
>  * either of the GNU General Public License Version 2 or later (the "GPL"),
>  * or the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
>  * in which case the provisions of the GPL or the LGPL are applicable instead
>  * of those above. If you wish to allow use of your version of this file only
>  * under the terms of either the GPL or the LGPL, and not to allow others to
>  * use your version of this file under the terms of the MPL, indicate your
>  * decision by deleting the provisions above and replace them with the notice
>- * and other provisions required by the GPL or the LGPL. If you do not delete
>- * the provisions above, a recipient may use your version of this file under
>+ * and other provisions required by the GPL or the LGPL. If you do not delete * the provisions above, a recipient may use your version of this file under

You shouldn't include this change when you check it in.

>Index: accessible/src/xul/nsXULFormControlAccessible.cpp
...
>+NS_IMETHODIMP nsXULTextFieldAccessible::GetExtState(PRUint32 *aExtState)
>+{
>+  nsresult rv = nsAccessible::GetExtState(aExtState);
>+  *aExtState |= EXT_STATE_SINGLE_LINE;
>+  return rv;
>+}

Is this right to mark all XUL textboxes as EXT_STATE_SINGLE_LINE? What about
textboxes with the multiline attribute?

Comment 7

[Aaron Leventhal]

(In reply to comment #6)
> Is this right to mark all XUL textboxes as EXT_STATE_SINGLE_LINE? What about
> textboxes with the multiline attribute?
You're right, I didn't know about those until today. I'll fix that before
checking in. 

Comment 8

[Aaron Leventhal]

Checking in src/base/nsAccessibilityAtomList.h;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityAtomList.h,v  <-- 
nsAccessibilityAtomList.h
new revision: 1.14; previous revision: 1.13
done
Checking in src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.132; previous revision: 1.131
done
Checking in src/base/nsFormControlAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsFormControlAccessible.cpp,v  <-- 
nsFormControlAccessible.cpp
new revision: 1.10; previous revision: 1.9
done
Checking in src/base/nsFormControlAccessible.h;
/cvsroot/mozilla/accessible/src/base/nsFormControlAccessible.h,v  <-- 
nsFormControlAccessible.h
new revision: 1.7; previous revision: 1.6
done
Checking in src/html/nsHTMLFormControlAccessible.cpp;
/cvsroot/mozilla/accessible/src/html/nsHTMLFormControlAccessible.cpp,v  <-- 
nsHTMLFormControlAccessible.cpp
new revision: 1.58; previous revision: 1.57
done
Checking in src/html/nsHTMLFormControlAccessible.h;
/cvsroot/mozilla/accessible/src/html/nsHTMLFormControlAccessible.h,v  <-- 
nsHTMLFormControlAccessible.h
new revision: 1.29; previous revision: 1.28
done
Checking in src/xul/nsXULFormControlAccessible.cpp;
/cvsroot/mozilla/accessible/src/xul/nsXULFormControlAccessible.cpp,v  <-- 
nsXULFormControlAccessible.cpp
new revision: 1.44; previous revision: 1.43
done
Checking in src/xul/nsXULFormControlAccessible.h;
/cvsroot/mozilla/accessible/src/xul/nsXULFormControlAccessible.h,v  <-- 
nsXULFormControlAccessible.h
new revision: 1.22; previous revision: 1.21
done