285741 - Scripts and plugins function in composer documents

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[[e-mail]]

Presumably as a result of bug 209020 and friends scripts and plugins are now
active in Composer documents. When the editor element is created the docShell's
allowJavascript is set to false. However when the document (event about:blank)
loads the allowJavascript value is set to true and is never reset to false.

Some Insert/HTML examples:
<applet> (without Java) will trigger the null plugin.
<script>alert('Boo!')</script> of course...
<script>document.write('Boo!')</script> might even crash.

This also applies to script in the source of the page.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Hmm...  Odd.  We do call SetAllowJavascript(PR_FALSE), right?  I wonder why that
doesn't work.  Do we restore the old value (in editor) when the document is created?

Comment 2

[[e-mail]]

Bug 209020 made TearDownEditor reset allowJavascript.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Sure, but if editing is torn down, why are we still able to edit the document?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Hmmm.... I see the value being reset to false in onload, but we're setting it on
the wrong docshell (the docshell we tore down on is a kid of the docshell we
catch onload for, looks like).

And in any case, during document load javascript is active.

This is something we really need to fix for 1.8/1.1/whatever...

Comment 5

[[e-mail]]

I don't know, I only had set a breakpoint at nsDocShell::SetAllowJavascript

Note that there are three docShells; the chrome docshell, the HTML view and the
source text view; the latter does have its javascript/plugins disabled.

Comment 6

[Johnny Stenback (:jst)]

Attachment: Only ever restore js/plugin etc state for midas.

Comment 7

[Kathleen :Brade]

Comment on attachment 177872 [details] [diff] [review]
Only ever restore js/plugin etc state for midas.

moa/r=brade (assuming you've tested Composer, Mail Compose and Midas)  bonus
points if you tested my sidebar ;-)

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 177872 [details] [diff] [review]
Only ever restore js/plugin etc state for midas.

sr=bzbarsky.

Comment 9

[Joe Sabash [:JoeS1]]

If someone could check this in before the next nightly, I could test it over the
weekend for Mail/News HTML compose, and a possible fix for bug #285343 as well

Comment 10

[Johnny Stenback (:jst)]

Fix checked in.

Comment 11

[Joe Sabash [:JoeS1]]

This seemed to fix problems with HTML replies to messages with JS or plugins.
Thanks jst
Bug #285343 fixed for WinXP not yet tested for Mac

Comment 12

[[e-mail]]

*** Bug 285343 has been marked as a duplicate of this bug. ***