286447 - Strip attachment (detach/delete) from message with odd quoting breaks MIME structure on rewrite

Status: RESOLVED FIXED

(MailNews Core :: Attachments, defect)

Description

[Mike Cowperthwaite]

Error with bug 2920's patch.  TB 1.0+0316, Windows 2000.

Given a plain message body which (incorrectly?) has an empty but quote-prefixed 
line immediately before the attachment's MIME boundary, if the attachment is 
stripped, the rewritten message is incorrect.  Specifically in this case, the 
boundary signifying the end of the message body is written onto the same line as 
the final (empty) quotemarks.  This causes the 'attachment/detachment' part to 
be treated as part of the message body.

  multipart/related; boundary=XXX
    --XXX
    text/plain
    blah
    >>quote
    >>
    --XXX
    application/x-whatever
    ....
    --XXX--

becomes
  multipart/related; boundary=XXX
    --XXX
    text/plain
    blah
    >>quote
    >>--XXX
    text/x-moz-deleted ...
    --XXX--

For a detachment, this has the effect of losing the capability to load the 
document.

Comment 1

[Mike Cowperthwaite]

Attachment: test case

Here's a sample to test with.
Steps to reproduce:
1) integrate this message into your mail system
2) View the message; delete and/or detach the attachment
3 [details] [diff] [review]) View the resulting message

Actual results:
3) Message body displayed includes the MIME boundary as the last line of the
quoted text, and then shows the moz-text-deleted headers and text inline; empty
attachment panel.

Expected results:
3) Message body unaltered; moz-text-deleted shown, at most, as inline
attachment data; item shown in panel.

Comment 2

[Mike Cowperthwaite]

This bug was fixed by the patch in attachment 179215 [details] [diff] [review] -- which was posted at the 
wrong bug, bug 286446.  Thanks, David!