Closed
Bug 286920
Opened 19 years ago
Closed 19 years ago
TestParser: --enable-perf-metrics with --disable-debug
Categories
(Core :: DOM: HTML Parser, enhancement)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(1 file)
3.91 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
TestParser: --enable-perf-metrics with --disable-debug As an example: ac_add_options --disable-debug ac_add_options --enable-optimize="-O2 -gstabs+" ac_add_options --enable-perf-metrics
Assignee | ||
Comment 1•19 years ago
|
||
Assignee | ||
Updated•19 years ago
|
Attachment #178020 -
Flags: superreview?(dbaron)
Attachment #178020 -
Flags: review?(dbaron)
Comment on attachment 178020 [details] [diff] [review] Patch rev. 1 I'm not sure who uses --enable-perf-metrics anymore, but... >Index: parser/htmlparser/public/Makefile.in >+REQUIRE_LOGGING_SINK = 0 >+ > ifdef MOZ_DEBUG >+REQUIRE_LOGGING_SINK = 1 >+endif >+ >+ifdef MOZ_PERF_METRICS >+REQUIRE_LOGGING_SINK = 1 >+endif >+ >+ifeq ($(REQUIRE_LOGGING_SINK),1) This could all be ifneq($(MOZ_DEBUG)$(MOZ_PERF_METRICS),) (since they're set to "1" when they're defined, so the string will be non-empty if either is defined). >Index: parser/htmlparser/src/Makefile.in Likewise. With that change, sr=dbaron.
Attachment #178020 -
Flags: superreview?(dbaron)
Attachment #178020 -
Flags: superreview+
Attachment #178020 -
Flags: review?(dbaron)
Attachment #178020 -
Flags: review+
Assignee | ||
Comment 3•19 years ago
|
||
Neat trick. Fixed as suggested and checked in 2005-03-20 15:54 PDT. -> FIXED
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•