Closed
Bug 287387
Opened 19 years ago
Closed 19 years ago
User mode changes always appear in current view, regardless of network
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rdmsoft, Assigned: rginda)
Details
(Whiteboard: [cz-patch][cz-0.9.68])
Attachments
(1 file, 1 obsolete file)
1.14 KB,
patch
|
samuel
:
review+
asa
:
approval1.8b2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050320 Firefox/1.0+ Build Identifier: Chatzilla 0.9.67 The onUserMode function in handlers.js uses display() instead of this.display(). Reproducible: Always Steps to Reproduce: 1. Connect to two networks. 2. Do the command "/mode (your nick) +i". 3. Quickly swap to a tab from a different network. Actual Results: The user mode message appears in the current view, so it's hard to tell which network the message came from. Expected Results: The message should always appear in a view of the correct network.
Reporter | ||
Comment 1•19 years ago
|
||
Updated•19 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Updated•19 years ago
|
Attachment #178366 -
Flags: review?(rginda)
Assignee | ||
Comment 2•19 years ago
|
||
Comment on attachment 178366 [details] [diff] [review] mini patch The MT_MODE line should be indented to appear under the character after the previous open paren, as in... this.display(getMsg... MT_MODE); Other than that, r=rginda
Attachment #178366 -
Flags: review?(rginda) → review+
Comment 3•19 years ago
|
||
Comment on attachment 178366 [details] [diff] [review] mini patch >+ this.display(getMsg(MSG_USER_MODE, [e.user.unicodeName, e.params[2]]), >+ MT_MODE); The second line should be lined up under the first parameter. See http://hacksrus.com/~ginda/pedant.html
Attachment #178366 -
Flags: review+ → review-
Reporter | ||
Comment 4•19 years ago
|
||
Attachment #178366 -
Attachment is obsolete: true
Attachment #178379 -
Flags: review?(samuel)
Updated•19 years ago
|
Attachment #178379 -
Flags: review?(samuel) → review+
Updated•19 years ago
|
Whiteboard: cz-patch
Updated•19 years ago
|
Attachment #178379 -
Flags: approval1.8b2?
Comment 5•19 years ago
|
||
Comment on attachment 178379 [details] [diff] [review] patch 2 a=asa
Attachment #178379 -
Flags: approval1.8b2? → approval1.8b2+
Comment 6•19 years ago
|
||
Checked in --> FIXED. Automated builds at http://twpol.dyndns.org/mozilla/chatzilla/nightly/ will include this shortly.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
Whiteboard: cz-patch → [cz-patch][cz-0.9.68]
You need to log in
before you can comment on or make changes to this bug.
Description
•