288017 - List bullet accessibles are not properly initialized & have no unique ID

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

I ran into this assertion during some browser torture tests:
"access node not initialized", nsAccessibleWrap.cpp #246
It was for list bullet accessibles

We don't Init() them, and they have no unique ID or entry into the cache.

Comment 1

[Aaron Leventhal]

Attachment: 1) Use |this| pointer for list bullet accessible unique ID, similar to what we do for tree items, 2) Initialize list bullet accessible when it is created, 3) Proper shutdown procedures

Comment 2

[[e-mail]]

Comment on attachment 178794 [details] [diff] [review]
1) Use |this| pointer for list bullet accessible unique ID, similar to what we do for tree items, 2) Initialize list bullet accessible when it is created, 3) Proper shutdown procedures

>+    mBulletAccessible = new nsHTMLListBulletAccessible(mDOMNode, mWeakShell, 
>+                                                   aBulletFrame, aBulletText);
>+    nsCOMPtr<nsPIAccessNode> bulletANode(do_QueryInterface(mBulletAccessible));
Note that instead of this silly QI (and the similar one in CacheChildren) you
could just make mBulletAccessible of nsRefPtr<nsHTMLListBulletAccessible> type.

Comment 3

[Aaron Leventhal]

Checking in src/html/nsHTMLTextAccessible.cpp;
/cvsroot/mozilla/accessible/src/html/nsHTMLTextAccessible.cpp,v  <-- 
nsHTMLTextAccessible.cpp
new revision: 1.40; previous revision: 1.39
done
Checking in src/html/nsHTMLTextAccessible.h;
/cvsroot/mozilla/accessible/src/html/nsHTMLTextAccessible.h,v  <-- 
nsHTMLTextAccessible.h
new revision: 1.28; previous revision: 1.27
done