Closed Bug 288137 Opened 19 years ago Closed 19 years ago

Update transliterate.properties to Unicode 4.x

Categories

(Core :: Internationalization, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smontagu, Assigned: smontagu)

References

Details

Attachments

(1 file, 1 obsolete file)

As well as regenerating the properties file with a current version of the
Unicode Character Database, this requires making nsIEntityConverter surrogate-aware.
Attached patch Patch (obsolete) — Splinter Review
This also includes the fix for bug 264946. 
I'm asking for reviews now, but if Unicode 4.1.0 is released before the freeze
for 1.8b2 I'll do another cycle with the new UnicodeData.txt
Attachment #178934 - Flags: review?(jshin1987)
Comment on attachment 178934 [details] [diff] [review]
Patch

r=jshin
Attachment #178934 - Flags: review?(jshin1987) → review+
Attachment #178934 - Flags: superreview?(rbs)
+          // never mind surrogates: none of these entities are outside the BMP
           else if (val > 127 && 

Actually, ȷ (just to cite an example) is a combined character in real life
-- but it was tricked into going to the PUA because not all platforms were
playing nice with surrogate pairs at the time. In the future, these PUA
re-assignmnents of entities might be removed.

Can you just use the surrogate-aware conversion there to bullet-proof the code
against future changes once for all?
I've tested this with |entity.120077=ȷ| hacked into mathml20.properties.

Transferring r=jshin
Attachment #178934 - Attachment is obsolete: true
Attachment #179052 - Flags: superreview?(rbs)
Comment on attachment 179052 [details] [diff] [review]
Added surrogate treatment to serializer

sr=rbs
Attachment #179052 - Flags: superreview?(rbs) → superreview+
Depends on: 288831
I forgot to mark this as fixed. It was checked in on 2005-04-02
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #178934 - Flags: superreview?(rbs)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: