289076 - plugin finder URL should not be localizable

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I don't see any reason for the plugin finder URL to be localizable.  Perhaps
customizable via something like prefs, but not in a file in the language pack. 
See bug 289013 for problems this causes.

Comment 1

[Axel Hecht]

The locale switching on the server side of the plugin finder service should
probably use the accept locale http header instead of some URL param, right?

Comment 2

[Mike Kaply [:mkaply]]

doron - this would help us as well (customizing plugin finder for inside a company)

Comment 3

[Doron Rosenberg (IBM)]

So would a preference be ok?

Note that I used the same thing EM uses
(http://lxr.mozilla.org/seamonkey/source/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties#15).

Comment 4

[Asa Dotzler [:asa]]

Doron, can you help us here?

Comment 5

[Doron Rosenberg (IBM)]

Preference it is.

Comment 6

[Benjamin Smedberg]

doron, for reference we should not rely on the accept-lang HTTP header, we
should dynamically code locale=@LOCALE@ in the preference and replace it at
runtime with the correct app locale (this is done by several of our services
already).

Comment 7

[Doron Rosenberg (IBM)]

Attachment: patch

Comment 8

[Doron Rosenberg (IBM)]

checked in.