Closed
Bug 289391
Opened 20 years ago
Closed 20 years ago
[FIX]No need to unbind native anonymous content in binding manager
Categories
(Core :: DOM: Core & HTML, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
1.87 KB,
patch
|
sicking
:
review+
peterv
:
superreview+
brendan
:
approval1.8b2+
|
Details | Diff | Splinter Review |
In bug 286000, I added a call to nsPresShell::SetAnonymousContentFor to
nsBindingManager::ChangeDocumentFor that clears out the anonymous content.
SetAnonymousContentFor calls UnbindFromTree on the anonymous content. So
there's no need to do it manually in the binding manager anymore.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #179925 -
Flags: superreview?(jst)
Attachment #179925 -
Flags: review?(bugmail)
|
|
Assignee | |
Updated•20 years ago
|
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta3
Attachment #179925 -
Flags: review?(bugmail) → review+
|
||
Updated•20 years ago
|
Attachment #179925 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Comment 2•20 years ago
|
||
Comment on attachment 179925 [details] [diff] [review]
Patch
Requesting approval for this removal of unneeded code.
Attachment #179925 -
Flags: approval1.8b2?
|
|
||
Comment 3•20 years ago
|
||
Comment on attachment 179925 [details] [diff] [review]
Patch
a=brendan for 1.8b2.
/be
Attachment #179925 -
Flags: approval1.8b2? → approval1.8b2+
|
|
Assignee | |
Comment 4•20 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.8beta3 → mozilla1.8beta2
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•