Closed Bug 289391 Opened 19 years ago Closed 19 years ago

[FIX]No need to unbind native anonymous content in binding manager

Categories

(Core :: DOM: Core & HTML, defect, P1)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

In bug 286000, I added a call to nsPresShell::SetAnonymousContentFor to
nsBindingManager::ChangeDocumentFor that clears out the anonymous content. 
SetAnonymousContentFor calls UnbindFromTree on the anonymous content.  So
there's no need to do it manually in the binding manager anymore.
Attached patch PatchSplinter Review
Attachment #179925 - Flags: superreview?(jst)
Attachment #179925 - Flags: review?(bugmail)
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta3
Attachment #179925 - Flags: superreview?(jst) → superreview+
Comment on attachment 179925 [details] [diff] [review]
Patch

Requesting approval for this removal of unneeded code.
Attachment #179925 - Flags: approval1.8b2?
Comment on attachment 179925 [details] [diff] [review]
Patch

a=brendan for 1.8b2.

/be
Attachment #179925 - Flags: approval1.8b2? → approval1.8b2+
Fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.8beta3 → mozilla1.8beta2
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: