Closed Bug 290175 Opened 19 years ago Closed 19 years ago

JS Error in permissionsNavigatorOverlay.xul

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

Attachments

(1 file, 1 obsolete file)

Revised Patch v0.1a (Checked in)
1.72 KB, patch
iannbugzilla
: review+
neil
: superreview+
asa
: approval1.8b2+
Details | Diff | Splinter Review 
When navigating through Tools menu you occasionally get an error in the JS
console with line 93 of permissionsNavigatorOverlay.xul
Attached patch Patch v0.1 (obsolete) — — Splinter Review 
This patch:
* Moves where pref is defined into SetPopupMenuEnabledState - the only place it
is used.
Attachment #180587 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #180587 - Flags: review?(neil.parkwaycc.co.uk)
Assignee: jag → bugzilla
Status: NEW → ASSIGNED
Comment on attachment 180587 [details] [diff] [review]
Patch v0.1

I assume this originally worked in olden days when global pref variables roamed
the codebase. But I think you might as well merge the two functions.
Attachment #180587 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #180587 - Flags: superreview-
Attachment #180587 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #180587 - Flags: review+
Changes since v0.1
* Merges SetPopupMenuEnabledState into it's calling function (the only one)

Carrying forward r= and requested sr=
Attachment #180587 - Attachment is obsolete: true
Attachment #180594 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #180594 - Flags: review+
Comment on attachment 180594 [details] [diff] [review]
Revised Patch v0.1a (Checked in)

It's the tools menu in view source - the browser has a global pref variable.
Attachment #180594 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Comment on attachment 180594 [details] [diff] [review]
Revised Patch v0.1a (Checked in)

Requesting a= for a very simple, very low risk patch
Attachment #180594 - Flags: approval1.8b2?
Comment on attachment 180594 [details] [diff] [review]
Revised Patch v0.1a (Checked in)

a=asa
Attachment #180594 - Flags: approval1.8b2? → approval1.8b2+
Comment on attachment 180594 [details] [diff] [review]
Revised Patch v0.1a (Checked in)

Checking in permissionsNavigatorOverlay.xul;
/cvsroot/mozilla/xpfe/components/permissions/content/permissionsNavigatorOverla
y.xul,v  <--  permissionsNavigatorOverlay.xul
new revision: 1.31; previous revision: 1.30
done
Attachment #180594 - Attachment description: Revised Patch v0.1a → Revised Patch v0.1a (Checked in)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: