290197 - unchecked outputstream [@ nsXULPrototypeScript::Serialize]

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[timeless]

+	aStream	0x00000000	nsIObjectOutputStream *

    // Write basic prototype data
    aStream->Write16(mLineNo);

 	gklayout.dll!nsXULPrototypeScript::Serialize(nsIObjectOutputStream *
aStream=0x00000000, nsIScriptContext * aContext=0x02111f10, const
nsCOMArray<nsINodeInfo> * aNodeInfos=0x00000000)  Line 4414 + 0xb	C++

-	objectOutput	{...}	nsCOMPtr<nsIObjectOutputStream>
\+	nsCOMPtr_base	{mRawPtr=0x00000000 }	nsCOMPtr_base
-	fastLoadService	{...}	nsCOMPtr<nsIFastLoadService>
\-	nsCOMPtr_base	{mRawPtr=0x00a750e0 {mRefCnt={mValue=0x00000003 }
mLock=0x01ce7448 mFastLoadPtrMap=0x00000000 {ops=??? data=??? hashShift=??? ...}
...} }	nsCOMPtr_base
 \-	mRawPtr	0x00a750e0 {mRefCnt={mValue=0x00000003 } mLock=0x01ce7448
mFastLoadPtrMap=0x00000000 {ops=??? data=??? hashShift=??? ...} ...}	nsISupports *
  \-	[nsFastLoadService]	{mRefCnt={mValue=0x00000003 } mLock=0x01ce7448
mFastLoadPtrMap=0x00000000 {ops=??? data=??? hashShift=??? ...} ...}
nsFastLoadService
   |+	nsIFastLoadService	{...}	nsIFastLoadService
   |+	mRefCnt	{mValue=0x00000003 }	nsAutoRefCnt
   |	mLock	0x01ce7448	PRLock *
   |+	mFastLoadPtrMap	0x00000000 {ops=??? data=??? hashShift=??? ...}	PLDHashTable *
   |+	mInputStream	{...}	nsCOMPtr<nsIObjectInputStream>
   |-	mOutputStream	{...}	nsCOMPtr<nsIObjectOutputStream>
   |\+	nsCOMPtr_base	{mRawPtr=0x00000000 }	nsCOMPtr_base
   |+	mFileIO	{...}	nsCOMPtr<nsIFastLoadFileIO>
   |	mDirection	0x00000000	int
   |+	mChecksumTable	{mLock=0x00000000 mHashtable={ops=0x0086e6c0 hashtableOps
data=0x00000000 hashShift=0x001c ...} mEnumerating=0x00000000 }	nsHashtable
   \+	__vfptr	0x0086ee18 const nsFastLoadService::`vftable'	*

    if (! objectOutput)
        fastLoadService->GetOutputStream(getter_AddRefs(objectOutput));

    rv = fastLoadService->
         StartMuxedDocument(mSrcURI, urispec.get(),
                            nsIFastLoadService::NS_FASTLOAD_WRITE);
    NS_ASSERTION(rv != NS_ERROR_NOT_AVAILABLE, "reading FastLoad?!");

    nsCOMPtr<nsIURI> oldURI;
    rv |= fastLoadService->SelectMuxedDocument(mSrcURI, getter_AddRefs(oldURI));
    rv |= Serialize(objectOutput, aContext, nsnull);
>	gklayout.dll!nsXULPrototypeScript::SerializeOutOfLine(nsIObjectOutputStream *
aStream=0x80040111, nsIScriptContext * aContext=0x02111f10)  Line 4508	C++

                        scriptProto->SerializeOutOfLine(nsnull, scriptContext);

 	gklayout.dll!nsXULDocument::OnStreamComplete(nsIStreamLoader *
aLoader=0x01e6c1c0, nsISupports * context=0x00000000, unsigned int
aStatus=0x00000000, unsigned int stringLen=0x01e67cfc, const unsigned char *
string=0x00000001)  Line 3210	C++
 	necko.dll!nsStreamLoader::OnStopRequest(nsIRequest * request=0x01d96e80,
nsISupports * ctxt=0x00000000, unsigned int aStatus=0x00000000)  Line 137	C++
 	jar50.dll!nsJARChannel::OnStopRequest(nsIRequest * req=0x00a74ca8, nsISupports
* ctx=0x00000000, unsigned int status=0x00000000)  Line 689	C++
 	necko.dll!nsInputStreamPump::OnStateStop()  Line 505	C++
 	necko.dll!nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream *
stream=0x01e78b20)  Line 342	C++
 	xpcom_core.dll!nsOutputStreamReadyEvent::EventHandler(PLEvent *
plevent=0x01d31884)  Line 119	C++
 	xpcom_core.dll!PL_HandleEvent(PLEvent * self=0x01d31884)  Line 693	C
 	xpcom_core.dll!PL_ProcessPendingEvents(PLEventQueue * self=0x00a4b108)  Line
627 + 0x6	C
 	xpcom_core.dll!_md_EventReceiverProc(HWND__ * hwnd=0x000c05b0, unsigned int
uMsg=0x0000c1aa, unsigned int wParam=0x00000000, long lParam=0x00a4b108)  Line
1434	C
 	user32.dll!GetDC()  + 0x6d	
 	user32.dll!GetDC()  + 0x14f	
 	user32.dll!GetWindowLongW()  + 0x127	
 	user32.dll!DispatchMessageW()  + 0xf	
 	gkwidget.dll!nsAppShell::Run()  Line 159	C++
 	appcomps.dll!nsAppStartup::Run()  Line 216	C++
 	mozilla.exe!main1(int argc=0x00000003, char * * argv=0x002a46f8, nsISupports *
nativeApp=0x00000015)  Line 1321 + 0x9	C++
 	mozilla.exe!main(int argc=0x00000003, char * * argv=0x002a46f8)  Line 1813 +
0x13	C++
 	mozilla.exe!WinMain(HINSTANCE__ * __formal=0x00400000, HINSTANCE__ *
__formal=0x00400000, char * args=0x00152318, HINSTANCE__ * __formal=0x00400000)
 Line 1841 + 0x17	C++
 	mozilla.exe!WinMainCRTStartup()  Line 390 + 0x1b	C
 	kernel32.dll!RegisterWaitForInputIdle()  + 0x49

Comment 1

[timeless]

Attachment: handle null

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 180606 [details] [diff] [review]
handle null

a=shaver

Comment 3

[timeless]

Comment on attachment 180606 [details] [diff] [review]
handle null

mozilla/content/xul/content/src/nsXULElement.cpp	1.573