Closed Bug 290907 Opened 19 years ago Closed 19 years ago

[FIXr]nsStorageStream crashes if used before init()

Categories

(Core :: XPCOM, defect, P1)

Product:
Core
Component:
XPCOM
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta2

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: crash)

Attachments

(1 file)

Proposed patch
3.79 KB, patch
Biesinger
: review+
darin.moz
: superreview+
asa
: approval1.8b2+
Details | Diff | Splinter Review 
nsStorageStream crashes if you call various methods on it without calling init()
(because mSegmentedBuffer is null and is not null-checked).  Perhaps it should
throw NS_ERROR_NOT_INITIALIZED instead?  That would make a lot more sense to me...
yes, i agree.
Severity: normal → critical
Keywords: crash
personally it would be fine with me if stuff crashes when not initialized, but
sure...
Attached patch Proposed patch — — Splinter Review 
Assignee: dougt → bzbarsky
Status: NEW → ASSIGNED

        Attachment #181191 -
        Flags: superreview?(darin)

        Attachment #181191 -
        Flags: review?(cbiesinger)

    
  
Priority: -- → P1
Summary: nsStorageStream crashes if used before init() → [FIX]nsStorageStream crashes if used before init()
Target Milestone: --- → mozilla1.8beta2

    
  

        Attachment #181191 -
        Flags: superreview?(darin) → superreview+

        Attachment #181191 -
        Flags: review?(cbiesinger) → review+

    
    

    
  
Comment on attachment 181191 [details] [diff] [review]
Proposed patch

Requesting 1.8b approval for this simple safety-fix...

        Attachment #181191 -
        Flags: approval1.8b2?

    
  
Summary: [FIX]nsStorageStream crashes if used before init() → [FIXr]nsStorageStream crashes if used before init()

    
    

    
  
Comment on attachment 181191 [details] [diff] [review]
Proposed patch

a=asa

        Attachment #181191 -
        Flags: approval1.8b2? → approval1.8b2+

    
    

    
  
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
    

    
  
*** Bug 247258 has been marked as a duplicate of this bug. ***

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: