Closed Bug 291198 Opened 19 years ago Closed 19 years ago

"overflow" and "underflow" events are missing detail attribute

Categories

(Core :: DOM: Events, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: stef, Assigned: stef)

References

Details

(Keywords: regression)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: 

Due to recent refactoring of the DOMEvent code (see #238773) the .detail
attribute on "overflow" and "underflow" events is missing. This is critical for
implementing things like horizontal tree scrolling (see #212789).

In nsEventListenerManager::CreateEvent, NS_SCROLLPORT_EVENT needs to be added to
the switch statement, and should call NS_NewDOMUIEvent().

Will attach a patch. 

Reproducible: Always
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 212789
Attached patch Fix for bugSplinter Review
This patch adds the necessary line. Requesting review of bryner since he
reviewed the refactoring patch (which caused the regression, ie: bug# 238773)
Attachment #181327 - Flags: superreview?(dbaron)
Attachment #181327 - Flags: review?(bryner)
Keywords: regression
Putting on the radar, 'cause I would really like bug 212789 for 1.8b2.
Flags: blocking1.8b2?
Flags: blocking-aviary1.1?
Attachment #181327 - Flags: superreview?(dbaron)
Attachment #181327 - Flags: superreview+
Attachment #181327 - Flags: review?(bryner)
Attachment #181327 - Flags: review+
Attachment #181327 - Flags: approval1.8b2+
Thanks David. Will you check this in? I don't have commit access, so I need to
find a committer. 
Fix checked in to trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Flags: blocking1.8b2?
Flags: blocking-aviary1.1?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: