Closed
Bug 291887
Opened 19 years ago
Closed 19 years ago
[FIXr]Document object creation calls Init() on zero-refcount objects
Categories
(Core :: DOM: Core & HTML, defect, P1)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
4.71 KB,
patch
|
jst
:
review+
jst
:
superreview+
brendan
:
approval1.8b2+
|
Details | Diff | Splinter Review |
One of my builds has ended up with a QI on the document called from inside the document's Init(), and this crashes because it kills off the document... We should be addrefing before calling Init().
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #181839 -
Flags: superreview?(jst)
Attachment #181839 -
Flags: review?(jst)
Comment 2•19 years ago
|
||
Comment on attachment 181839 [details] [diff] [review] Proposed patch r+sr=jst
Attachment #181839 -
Flags: superreview?(jst)
Attachment #181839 -
Flags: superreview+
Attachment #181839 -
Flags: review?(jst)
Attachment #181839 -
Flags: review+
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 181839 [details] [diff] [review] Proposed patch Requesting 1.8b approval. This is very safe, and makes document object creation follow the basic COM "don't call Init() on an object with a refcount of 0" rule.
Attachment #181839 -
Flags: approval1.8b2?
Assignee | ||
Updated•19 years ago
|
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Summary: [FIX]Document object creation calls Init() on zero-refcount objects → [FIXr]Document object creation calls Init() on zero-refcount objects
Target Milestone: --- → mozilla1.8beta2
Comment 4•19 years ago
|
||
Comment on attachment 181839 [details] [diff] [review] Proposed patch a=me for 1.8b2. /be
Attachment #181839 -
Flags: approval1.8b2? → approval1.8b2+
Assignee | ||
Comment 5•19 years ago
|
||
Fixed
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•