Closed
Bug 291897
Opened 19 years ago
Closed 19 years ago
GNOME shell services needs nsIGdkPixbufImage.h
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
Details
Attachments
(1 file)
3.31 KB,
patch
|
blizzard
:
review+
blizzard
:
superreview+
asa
:
approval1.8b2+
|
Details | Diff | Splinter Review |
Need to make it depend on widget so that this include file can be found, now that we've moved it.
Assignee | ||
Comment 1•19 years ago
|
||
This gets the GNOME shell service building again. If it only builds with GTK2 anyway, then the changes in the .cpp file can be ignored. Let me know.
Attachment #181847 -
Flags: superreview?(blizzard)
Attachment #181847 -
Flags: review?(blizzard)
Comment 2•19 years ago
|
||
Comment on attachment 181847 [details] [diff] [review] fix Sounds good to me
Attachment #181847 -
Flags: superreview?(blizzard)
Attachment #181847 -
Flags: superreview+
Attachment #181847 -
Flags: review?(blizzard)
Attachment #181847 -
Flags: review+
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 181847 [details] [diff] [review] fix need approval to fix build breakage
Attachment #181847 -
Flags: approval1.8b2?
Comment 4•19 years ago
|
||
Comment on attachment 181847 [details] [diff] [review] fix a=asa
Attachment #181847 -
Flags: approval1.8b2? → approval1.8b2+
Assignee | ||
Comment 5•19 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 6•19 years ago
|
||
(In reply to comment #1) > This gets the GNOME shell service building again. If it only builds with GTK2 > anyway, then the changes in the .cpp file can be ignored. Let me know. From Makefile.in: ifeq ($(MOZ_WIDGET_TOOLKIT), gtk2) CPPSRCS = nsGNOMEShellService.cpp So your change to Makefile.in would suffice.
You need to log in
before you can comment on or make changes to this bug.
Description
•