Closed Bug 291897 Opened 19 years ago Closed 19 years ago

GNOME shell services needs nsIGdkPixbufImage.h

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(1 file)

Need to make it depend on widget so that this include file can be found, now
that we've moved it.
Attached patch fixSplinter Review
This gets the GNOME shell service building again. If it only builds with GTK2
anyway, then the changes in the .cpp file can be ignored. Let me know.
Attachment #181847 - Flags: superreview?(blizzard)
Attachment #181847 - Flags: review?(blizzard)
Comment on attachment 181847 [details] [diff] [review]
fix

Sounds good to me
Attachment #181847 - Flags: superreview?(blizzard)
Attachment #181847 - Flags: superreview+
Attachment #181847 - Flags: review?(blizzard)
Attachment #181847 - Flags: review+
Comment on attachment 181847 [details] [diff] [review]
fix

need approval to fix build breakage
Attachment #181847 - Flags: approval1.8b2?
Comment on attachment 181847 [details] [diff] [review]
fix

a=asa
Attachment #181847 - Flags: approval1.8b2? → approval1.8b2+
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
(In reply to comment #1)
> This gets the GNOME shell service building again. If it only builds with GTK2
> anyway, then the changes in the .cpp file can be ignored. Let me know.

From Makefile.in:

ifeq ($(MOZ_WIDGET_TOOLKIT), gtk2)
CPPSRCS = nsGNOMEShellService.cpp

So your change to Makefile.in would suffice.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: