Closed
Bug 292503
Opened 19 years ago
Closed 19 years ago
Working images have alt text that says they are invalid
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: Bugzilla-alanjstrBugs, Assigned: csthomas)
References
()
Details
(Keywords: fixed1.8)
Attachments
(1 file)
|
2.69 KB,
patch
|
Biesinger
:
review+
jst
:
superreview+
cbeard
:
approval1.8b4+
|
Details | Diff | Splinter Review |
If you load an image, due to the hack for bug 9796, the browser has alt text that says "the image .... cannot be displayed, because it contains errors." This isn't right if the image doesn't have errors. This has caused bug 157006. A solution to this bug might be tied in with bug 133933 which also suggests using alt text.
|
||
Comment 1•19 years ago
|
||
*** Bug 297090 has been marked as a duplicate of this bug. ***
|
||
Comment 2•19 years ago
|
||
see also bug 177747
|
Assignee | |
Comment 3•19 years ago
|
||
During load, the alt text is the URL. After load, the alt text is unchanged except in the case of error, in which case the same error message as before is displayed.
Assignee: pavlov → cst
Status: NEW → ASSIGNED
Attachment #191842 -
Flags: superreview?(jst)
Attachment #191842 -
Flags: review?(cbiesinger)
|
|
Assignee | |
Updated•19 years ago
|
Severity: normal → minor
OS: Windows 2000 → All
Target Milestone: --- → mozilla1.8beta4
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [cst: r?]
|
||
Comment 4•19 years ago
|
||
Comment on attachment 191842 [details] [diff] [review] patch + NS_ConvertUTF8toUCS2 srcString(src); s/UCS2/UTF16/, please. ah, and if you make a new patch anyway ;) please also remove the 1 here: + const PRUnichar* formatString[1] = { srcString.get() }; (better if someone wants to add a new string here) why the wrong indentation here: + getter_Copies(errorMsg));
Attachment #191842 -
Flags: review?(cbiesinger) → review+
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [cst: r?] → [cst: sr?]
|
||
Comment 5•19 years ago
|
||
Comment on attachment 191842 [details] [diff] [review] patch sr=jst
Attachment #191842 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #191842 -
Flags: approval1.8b4?
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [cst: sr?] → [cst: a?]
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [cst: a?] → [cst: a?] [cst:fixed-trunk]
|
|
||
Updated•19 years ago
|
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [cst: a?] [cst:fixed-trunk] → [cst: a?] [cst:fixed-trunk] [cst: land fix for biesi's comments when tree opens]
|
||
Updated•19 years ago
|
Attachment #191842 -
Flags: approval1.8b4? → approval1.8b4+
|
|
||
Comment 6•19 years ago
|
||
bug 305215's patch addresses the review comments here.
|
|
Assignee | |
Updated•19 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Whiteboard: [cst: a?] [cst:fixed-trunk] [cst: land fix for biesi's comments when tree opens]
|
||
Comment 7•19 years ago
|
||
Does this fix bug 177747?
|
|
||
Comment 8•19 years ago
|
||
the dependencies can probably be marked fixed now...
|
||
Comment 9•19 years ago
|
||
(In reply to comment #7) > Does this fix bug 177747? "No": see bug 177747 comment 34.
|
||
Comment 10•19 years ago
|
||
I filed bug 315870. It may be regression of this. When Firefox loaded a invalid image file directly, we can see the URL instead of error message.
You need to log in
before you can comment on or make changes to this bug.
Description
•