292637 - nsSchemaLoader can't load file:// urls

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect)

Description

[Doron Rosenberg (IBM)]

Comment 1

[Doron Rosenberg (IBM)]

Attachment: code currently is http-centric, make it work from file:// as well.

Not sure if I need any security checks.

Comment 2

[Doron Rosenberg (IBM)]

Comment on attachment 182408 [details] [diff] [review]
code currently is http-centric, make it work from file:// as well.

Since SchemaLoader works from non-chrome js, are any security checks needed?

Comment 3

[Doron Rosenberg (IBM)]

Attachment: cleaner pastch

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 182412 [details] [diff] [review]
cleaner pastch

+  if (eventType.EqualsLiteral("load")) {
[...]
+	 succeeded = PR_TRUE;
[...]
+  }
+
+  if (succeeded && eventType.EqualsLiteral("load")) {

Maybe move this succeeded check into the above eventType.EqualsListeral("load")
check to eliminate the redundant "load" check?

sr=jst

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 182412 [details] [diff] [review]
cleaner pastch

+      if (!StringBeginsWith(spec, NS_LITERAL_CSTRING("http:")) &&
+	   !StringBeginsWith(spec, NS_LITERAL_CSTRING("https:"))) {

uri->SchemeIs("http")?

or you could check if the channel QIs to nsIHttpChannel

either way, r=biesi

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 182412 [details] [diff] [review]
cleaner pastch

a=mkaply

Comment 7

[Doron Rosenberg (IBM)]

checked in with the QI method