292656 - Drop-down selection box with CSS height attribute grows in width when changing selection

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jan Darmochwal]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050502
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050502

Changing the selection of a drop-down selection with non-auto height attribute
increases the horizontal size of the selection box.

Reproducible: Always

Steps to Reproduce:
1. Change the selection of a drop-down selection box with style="heigth: <value>;"

Actual Results:  
The horizontal size of the selection box increases whenever the selection changes.

Expected Results:  
The size does not change.

Comment 1

[Jan Darmochwal]

Attachment: testcase

Comment 2

[Thomas K. (:tom)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050419
Firefox/1.0.4

Doesn't happen here, if you mean the dropdown selection area constantly widens.
 It's a little bit wider than the original box with the down arrow, but it
doesn't grow in width.

Comment 3

[Jan Darmochwal]

(In reply to comment #2)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050419
> Firefox/1.0.4

This bug has regressed between 20050428 and 20050429, can you try to confirm it
with a recent nightly?

> Doesn't happen here, if you mean the dropdown selection area constantly widens.
>  It's a little bit wider than the original box with the down arrow, but it
> doesn't grow in width.

Every time you change the selection, the original box grows in size.

Comment 4

[Andrew Schultz]

confirmed with linux trunk build 2005050205
this regressed between linux trunk 2004042805 and 2005042901 (bug 240276)

I get three of these:
###!!! ASSERTION: We assume that the vertical scrollbar width is fixed:
'aMin->width == pref.width', file nsGfxScrollFrame.cpp, line 325
and then one:
###!!! ASSERTION: We assume that the horizontal scrollbar height is fixed:
'aMin->height == pref.height', file nsGfxScrollFrame.cpp, line 328

==> roc

Comment 5

[Thomas K. (:tom)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050502
Firefox/1.0+

Confirmed, it does indeed grow wider every time I select something.

Comment 6

[Peter van der Woude [:Peter6]]

*** Bug 293508 has been marked as a duplicate of this bug. ***

Comment 7

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050508
Firefox/1.0+

confirming

OS ->All

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

fixed by 292656? It works in my trunk build

Comment 9

[Caleb]

(In reply to comment #8)
> fixed by 292656? It works in my trunk build

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050525
Firefox/1.0+ ID:2005052510

Actually, no, it is not fixed.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You have to focus the <select> and then use the arrow keys to change the
selection. Changing the selection with the mouse doesn't do it.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Wait, yes it does. Sorry!

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

The combobox code caches dropdown size information for "fully unconstrained"
reflows (where both the computed width and height are auto). Unfortunately for
non "fully unconstrained" reflows where the height is known but the width is
auto, it screws up. We should just treat any reflow with specified computed
width as "fully unconstrained" even if there is a computed height, because the
dropdown size is not affected at all by the computed height. This fixes the
bug.

Comment 13

[Caleb]

Comment on attachment 186445 [details] [diff] [review]
fix

Requesting approval

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 15

[Adam Guthrie]

*** Bug 212845 has been marked as a duplicate of this bug. ***

Comment 16

[Adam Guthrie]

*** Bug 261391 has been marked as a duplicate of this bug. ***

Comment 17

[Adam Guthrie]

*** Bug 215916 has been marked as a duplicate of this bug. ***

Comment 18

[Adam Guthrie]

*** Bug 253679 has been marked as a duplicate of this bug. ***

Comment 19

[Adam Guthrie]

*** Bug 223977 has been marked as a duplicate of this bug. ***

Comment 20

[Adam Guthrie]

*** Bug 269170 has been marked as a duplicate of this bug. ***