292662 - [FIX]green and yellow outline of loading images

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050502
Firefox/1.0+

repro:
1.Open FF
2.Open url
3.Carefully watch the outline of the images that are loading

this regressed in the past week

Comment 1

[Peter van der Woude [:Peter6]]

Attachment: screenshot

notice that not all borders are the same color (see alrger colorblocks)
also the bordercolor varies per image

ps. this has nothing to do with deviantart, it's just used because the images
load so slow.

can be seen on any page with slow loading images

Comment 2

[Steve England [:stevee]]

I see this on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2)
Gecko/20050502 Firefox/1.0+
I do not see this on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2)
Gecko/20050422 Firefox/1.0+

Comment 3

[Steve England [:stevee]]

I see this on many pages. Best way to reproduce is go to one of theses sites
- http://news.bbc.co.uk/
- http://miranda-im.org/download/
-  http://www.fce2.de/main.htm 
Do a CTRL-Refresh and then hit stop as the page starts rendering.

Comment 4

[Peter van der Woude [:Peter6]]

regressed between the 20050429 0731pdt and 20050429 1210 pdt builds

range 
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-04-29+0830&maxdate=2005-04-29+1125&cvsroot=%2Fcvsroot

main suspect bug 290377

cc Bzbarsky

Comment 5

[Joël Kuiper]

Attachment: testcase

This testcase show the behaviour. Note that the testcase is in quirks mode, in
strict mode (thus specifying a strict doctype) makes the behavior disappear

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

The old code (before bug 290377 was fixed) had:

  mBorderColor[0] = 0;

etc.  This patch has the same effect (though note that this sets the alpha in
the color correctly, so won't break when we start supporting that).  Also, I
need to use SetBorderColor (per comment) because I'm not setting mBorderStyle
directly.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 182435 [details] [diff] [review]
Fix

Requesting approval for simple regression fix -- just making sure to initialize
members in a constructor.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 182435 [details] [diff] [review]
Fix

a=asa

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed