293219 - Canvas mixes up RGB order in fillStyle and strokeStyle properties

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jens Bannmann]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050506 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050506 Firefox/1.0+

In RGB(A) strings, the Red and Blue parts are reversed. This happens regardless
of the syntax used (#FF0000 or rgba(255,...)).

Reproducible: Always

Steps to Reproduce:
1. Load the attached testcase

Actual Results:  
Blue-green-red boxes and a long ice-blue box below it.

Expected Results:  
Red-green-blue boxes and a long orange box below it.

Comment 1

[Jens Bannmann]

Attachment: test case

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Just checked in a tiny patchlet for this; should be in tomorrow's build.  Can
you try with that tomorrow and verify?

Comment 3

[Jens Bannmann]

Verified using a Beast tinderbox build. Thanks for the quick fix!

Comment 4

[Sjoerd Visscher]

Could it be possible that this patch only works for opaque colors, and that a
similar patch is needed in the transparency code?

Comment 5

[Jens Bannmann]

(In reply to comment #4)
> Could it be possible that this patch only works for opaque colors, and that a
> similar patch is needed in the transparency code?

That sounds like bug 293353.