294073 - ISimpleDOMNode uniqueID not returning values that match childID's

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

We're using the old method of calculating unique ID's in get_nodeInfo(). We
should just be using GetUniqueID() which does all the work.

Comment 1

[Aaron Leventhal]

Attachment: Reuse GetUniqueID() method, and negate value in the same way that other code already does for event child ID's

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 183541 [details] [diff] [review]
Reuse GetUniqueID() method, and negate value in the same way that other code already does for event child ID's

OK, I guess, though after NS_PTR_TO_INT32 it's no longer unique, in general.

Comment 3

[Aaron Leventhal]

(In reply to comment #2)
> (From update of attachment 183541 [details] [diff] [review] [edit])
> OK, I guess, though after NS_PTR_TO_INT32 it's no longer unique, in general.
> 

It's the same as we use elsewhere in our MSAA code because there is no support
for MSAA on 64 bit platforms.

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 183541 [details] [diff] [review]
Reuse GetUniqueID() method, and negate value in the same way that other code already does for event child ID's

a=mkaply

Comment 5

[Aaron Leventhal]

Checking in accessible/src/msaa/nsAccessNodeWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsAccessNodeWrap.cpp,v  <-- 
nsAccessNodeWrap.cpp
new revision: 1.16; previous revision: 1.15
done