294407 - Saved Searches properties has wrong title/description

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[Ian Neal]

When you look at the properties of a saved search / virtual folder the dialog
box that comes up has the title "New Saved Search Folder" and the description
for the search criteria is "Configure the search criteria used for this virtual
folder" instead of "Modify the search criteria used for this saved search"

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: patch using document.title instead of window.title (Checked in)

Ok, this bug is caused by bug 264102. window.title is deprecated. Instead
document.title has to be used.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thunderbird uses the same code.

=> Core

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 188026 [details] [diff] [review]
patch using document.title instead of window.title (Checked in)

Neil, this patch will fix your mentioned problem in not updating the title when
editing an existing saved search.

Comment 4

[Karsten Düsterloh]

JFTR: this bug was spun off from bug 293682 initially.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 188026 [details] [diff] [review]
patch using document.title instead of window.title (Checked in)

sr=dmose

Comment 6

[Ian Neal]

Comment on attachment 188026 [details] [diff] [review]
patch using document.title instead of window.title (Checked in)

Checking in virtualFolderProperties.js;
new revision: 1.12; previous revision: 1.11
done

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with SeaMonkey 1.0a Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2)
Gecko/20050702 SeaMonkey/1.0a and Thunderbird version 1.0+ (20050702)

Comment 8

[Caio Tiago Oliveira (asrail)]

I can confirm both the wrong title and wrong search criteria (none criteria), as if creating a new search.
There is also no checked folder to search.


Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060429 SeaMonkey/1.5a

Comment 9

[Ian Neal]

This is not the same problem, I have opened bug 336100 on this new problem.