Closed Bug 295046 Opened 19 years ago Closed 19 years ago

can't open detached attachments

Categories

(MailNews Core :: Attachments, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ajschult784, Assigned: neil)

Details

Attachments

(1 file)

With linux suite trunk 2005052002, after detaching an attachment, I can't open
it.  The file is saved properly to disk and the message source looks ok (it's
the same as it is in Thunderbird which can open detached attachments).

1. start with a message with a single attachment
2 [details] [diff] [review]. detach the attachment
3 [details] [diff] [review]. "open" the detached attachment

==> browser window tries to load something like:
mailbox:///home/andrew/.mozilla/clean/xxxxxxxx.slt/Mail/Local%20Folders/bar?number=503816
which is the whole message, but with only the headers from the attachment. 
Adding the relevant query string the attachment would have if it still existed
("&part=1.2&type=text/plain&filename=file") brings up the headers.

Thunderbird properly loads the detached attachment in the message window when I
select "open" (although it doesn't give me a way to get back).
CCing someone who actually knows how opening detached attachments works...
cc'ing someone who actually knows how opening external attachments works :-) 

now that I think of it, Scott might have done some thunderbird-specific things
to make this work (external attachments were originally done to handle things
like pod-casting in rss feeds)
It looks like there are two parts to fix for this bug.

The first part is that I don't pass in the isExternalAttachment flag.

The second part is that the attachment then loads in the message pane.
Attached patch Proposed patchSplinter Review
The nsMessenger change makes it so that the load looks like a link click and
therefore gets redirected to a browser or save window. (This is the same effect
that you get when opening an internal attachment). The change does not appear
to regress opening attached messages, which was when the code was introduced.

Note that I don't think this really fixes saving external attachments.
Attachment #184312 - Flags: superreview?(bienvenu)
Attachment #184312 - Flags: review?(bienvenu)
I'm going to run with the nsMessenger change in my thunderbird tree, just to
make sure it works in TB.
Comment on attachment 184312 [details] [diff] [review]
Proposed patch

I've been running with this for a while and haven't had a problem in tbird.
Attachment #184312 - Flags: superreview?(bienvenu)
Attachment #184312 - Flags: superreview+
Attachment #184312 - Flags: review?(bienvenu)
Attachment #184312 - Flags: review+
Attachment #184312 - Flags: approval1.8b3?
Comment on attachment 184312 [details] [diff] [review]
Proposed patch

a=chofmann
Attachment #184312 - Flags: approval1.8b3? → approval1.8b3+
(In reply to comment #0)
>Thunderbird properly loads the detached attachment in the message window when I
>select "open" (although it doesn't give me a way to get back).
Actually I don't think loading the detached attachment in the message window is
the proper thing to do here. I wonder what Thunderbird now does post-checkin...
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
(In reply to comment #8)
> (In reply to comment #0)
> > Thunderbird properly loads the detached attachment in the message window'
> > when I select "open" (although it doesn't give me a way to get back).
> Actually I don't think loading the detached attachment in the message
> window is the proper thing to do here. I wonder what Thunderbird now does
> post-checkin...

I just tried under Win2K: a plain-text detached item puts up a prompt asking 
What Should TB Do With This File?  Open/Save to Disk.
This is better than the old way, I agree.
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: