295173 - XRemoteClient leaks in some places

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect)

Description

[Ferdinand]

I ran mozilla through valgrind and saw a leak (8 blocks) here:
http://lxr.mozilla.org/seamonkey/source/widget/src/xremoteclient/XRemoteClient.cpp#261
http://lxr.mozilla.org/seamonkey/source/widget/src/xremoteclient/XRemoteClient.cpp#297
http://lxr.mozilla.org/seamonkey/source/widget/src/xremoteclient/XRemoteClient.cpp#453
These three don't XFree when they're done.

Comment 1

[Ferdinand]

Attachment: patch to XFree in 3 places

I've run mozilla through valgrind with this patch, and the leaks are gone.

Comment 2

[Ferdinand]

Attachment: better diff, small whitespace changes

Comment 3

[Bastiaan Jacques]

Can we get bug going again? blizzard, are you able to do this review?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Requesting blocking.  Have patch for leak bug, just need module owner to
actually review sometime...

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 184676 [details] [diff] [review]
better diff, small whitespace changes

let's get this landed.

Comment 6

[Asa Dotzler [:asa]]

we shouldn't have to block on this since it's ready to land. minusing as a
blocker to keep that list saner (but of course we want it in)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed, trunk and 1.8 branch.