296388 - canvas 2d rendering context drawWindow gives a non-informative error when passed a null window

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[(not currently active) Ted Mielczarek]

Passing null as the first argument to drawWindow (from javascript) gives
NS_ERROR_FAILURE.  It would be nice to give NS_ERROR_INVALIDARG or something
more descriptive.

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Also the case for |undefined|, I bet.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: Trivial patch

Adds NS_ENSURE_ARG after the security check.  I used that in place of
NS_ENSURE_ARG_PTR because the error return value makes a little more sense in
javascript, where you don't have pointers.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 186975 [details] [diff] [review]
Trivial patch

r=vladimir, sounds good

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 186975 [details] [diff] [review]
Trivial patch

Trivial better error message

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

checked in, thanks