296405 - nsAccessible::GetLastChild broken

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[parente]

Using mozinspect, navigating to the last child returns the first child.

Comment 1

[parente]

Attachment: Makes negative index last child index

Comment 2

[Aaron Leventhal]

Comment on attachment 185167 [details] [diff] [review]
Makes negative index last child index

// If aChildNum is out of ranger larger than numChildren, return null

- Nit: Spelling error on ranger

- Important: let's change the documentation for this method in
nsIAccessible.idl to reflect/clarify the new interface rules.

Comment 3

[parente]

Attachment: GetChildAt supports negative index (public and src)

Comment 4

[[e-mail]]

Comment on attachment 185185 [details] [diff] [review]
GetChildAt supports negative index (public and src)

>+  // If aChildNum is out of range larger than numChildren, return null
>   if (aChildNum >= numChildren || !mWeakShell) {
>     *aChild = nsnull;
>     return NS_ERROR_FAILURE;
>+  // If aChildNum is out of range less than zero, set aChild to last index
>+  } else if (aChildNum < 0) {
>+    aChildNum = numChildren - 1;
What if there are no children?

I'm not sure that the "out of range" phrases are necessary.

Comment 5

[parente]

Attachment: Fixes separate bug of not having children

Comment 6

[Aaron Leventhal]

Checking in accessible/public/nsIAccessible.idl;
/cvsroot/mozilla/accessible/public/nsIAccessible.idl,v  <--  nsIAccessible.idl
new revision: 1.41; previous revision: 1.40
done
Checking in accessible/src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.154; previous revision: 1.153
done