Closed
Bug 297973
Opened 19 years ago
Closed 19 years ago
It's possible to allocate a nsAString in the Gecko SDK
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.8beta3
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
Attachments
(1 file)
|
2.45 KB,
patch
|
bryner
:
review+
dbaron
:
superreview+
asa
:
approval1.8b3+
|
Details | Diff | Splinter Review |
It's possible to allocate a nsAString in the Gecko SDK. We should make it so that "nsAString foo;" does not compile. Writing code like that results in the nsAString not being initialized properly, and attempting to use it will result in a crash. This only applies to the Gecko SDK (i.e., the version of nsAString defined in nsStringAPI.h).
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #186538 -
Flags: superreview?(dbaron)
Attachment #186538 -
Flags: review?(bryner)
|
|
Assignee | |
Comment 2•19 years ago
|
||
I want to backport this fix to the 1.7 branch as well since people generally use the SDK from the 1.7 branch in order to support Firefox 1.0 and 1.1.
Severity: normal → minor
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta3
Attachment #186538 -
Flags: superreview?(dbaron) → superreview+
|
||
Updated•19 years ago
|
Attachment #186538 -
Flags: review?(bryner) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #186538 -
Flags: approval1.8b3?
Attachment #186538 -
Flags: approval1.7.9?
|
||
Updated•19 years ago
|
Attachment #186538 -
Flags: approval1.8b3? → approval1.8b3+
|
|
Assignee | |
Comment 3•19 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•19 years ago
|
||
Comment on attachment 186538 [details] [diff] [review] v1 patch unsetting 1.7.9 approval request since that release has already shipped.
Attachment #186538 -
Flags: approval1.7.9?
|
||
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•