298378 - li in columns render corrupt when zoomed

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Felix Miata]

To reproduce:
1-load testcase
2-ctrl++ 3 times

Actual results:
1-content of .linklist disappears
2-too many list items for alloted right column space
3-right column of .linkscol2 text overlaps

Expected results:
1-everything paints properly

Notes:
1-Tested on XP on current DP and on Linux on current trunk.
2-ctrl+- fixes it
3-reload fixes it
4-text-decoration: underline not necessary, just highlights problem at lesser zoom
5-if inline styles are removed from the testcase, the content of .linklist fails
to disappear on zoom

Comment 1

[Felix Miata]

Attachment: testcase with inline styles

Comment 2

[Felix Miata]

Attachment: testcase with no inline styles

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

What happens is that the first reflow of the columnset is a stylechanged reflow.
But because we increased the fontsize, some of the child elements don't fit,
they move to the overflow list and don't get reflowed. Then the column set
adjusts the column height and reflows the elements again with a resize reflow.
This time the elements fit but the resize-reflow optimizations decide that some
of the child elements' lines don't need to be marked dirty, so they never get
the reflow that the style-change reflow demanded.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

David's reflow branch will fix this properly. In the meantime I can have the
column set keep issuing style-change reflows until the columns are complete, at
which point we know that all children have been reflowed.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Fairly simple fix to incremental-reflow issue in columns ... but really your
reflow branch is needed here.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 187100 [details] [diff] [review]
fix

incremental reflow fix, affects columns only

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in