298661 - Missing realname in messagepane when no mail address given

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Tilmann Reh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.7.8) Gecko/20050511 Mnenhy/0.7.2.10003
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.7.8) Gecko/20050511 Mnenhy/0.7.2.10003

When a mail or news message contains only a realname in the from: field, but an
empty mail address, nothing is displayed as from: in the header area of the
messagepane (3pane view). It is however shown correctly in the message list, and
if the header is displayed in brief mode only.
Seemingly a small problem in the UI code.
(I know that with Mozilla, you can't even generate such broken from: data, but
there are other clients around...)


Reproducible: Always

Steps to Reproduce:
For generating such a broken "test" message, simply edit an existing mail file
and delete the sender's mail address of a particular message, leaving just the
surrounding "<" and ">" without anything between.
Actual Results:  
In normal view, the from: field is empty in the messagepane.

Expected Results:  
The (given) realname should be displayed.

This bug is also reproducible with the current nightlies (1.8a2, 2005062x).

Comment 1

[Jürgen 'JiHa' Harter]

reproducible also with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050623
Mnenhy/0.7.2.10003

Comment 2

[Karsten Düsterloh]

Attachment: show display name at least if full name is broken

JFTR: This is reproducable even without Mnenhy. ;-)
The problem is that the function updateEmailAddressNode in
<http://lxr.mozilla.org/mozilla/source/mailnews/base/resources/content/msgHdrViewOverlay.js#839>
gets an empty fullName in this special case. If the displayName is empty, too,
then there's really nothing to show...

Comment 3

[Stefan Borggraefe]

Hmm, wouldn't it be better to fix msg_make_full_address() so it returns
something useful in this special case, too?

Comment 4

[Karsten Düsterloh]

> Hmm, wouldn't it be better to fix msg_make_full_address() so it returns
> something useful in this special case, too?

I don't think so, because there simply is *no* valid full address in this case.
The patch just shows at least something (if at all) the user can click as he's used.

Comment 5

[Karsten Düsterloh]

Comment on attachment 187205 [details] [diff] [review]
show display name at least if full name is broken

Suite only, very low risk.

Comment 6

[Karsten Düsterloh]

Checking in msgHdrViewOverlay.js;
/cvsroot/mozilla/mailnews/base/resources/content/msgHdrViewOverlay.js,v  <-- 
msgHdrViewOverlay.js
new revision: 1.139; previous revision: 1.138
done