299982 - forward message filter doesn't work if msg quarantining on download turned on.

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[David :Bienvenu]

If message quarantining is turned on for new pop3 mail, auto-forward message
filters won't work on download because they attempt to read the message from the
mail folder, not the quarantined temp file. We could either try to run filters
after we've un-quarantined the message (but that could involve copying the
message twice in the case of a move filter), or we could try to generate a uri
to the temp file message instead of the msg in the mail folder. But the
parsemailbox code doesn't even know about the temp download file, plus the temp
file could get written over in the middle of trying to attach the message, as we
fetch the next message, so I think that's out. We could postpone the
reply/forward filter actions until after the quarantining, perhaps with a timer.
But if there's a subsequent filter action that moves the message, we're
definitely hosed...

Comment 1

[David :Bienvenu]

Attachment: proposed fix

for local filters, we now remember in the mailbox parser the reply/forward
actions, and after applying the rest of the filters, apply the reply/forward
actions in a second pass. We also remember the hdr we want to apply the
reply/forward actions, so if we move the message to another local folder, we'll
remember that header instead. We only have to remember one header because it's
always the same header.

Comment 2

[Benjamin Smedberg]

Comment on attachment 188983 [details] [diff] [review]
proposed fix

Please get rid of the commented-out NS_ASSERTION