Closed
Bug 300550
Opened 19 years ago
Closed 19 years ago
"toString" enumerable on window.location
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ian, Assigned: peterv)
References
()
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
jst
:
review+
brendan
:
superreview+
brendan
:
approval1.8b4+
|
Details | Diff | Splinter Review |
Brendan asked me to file this. When you enumerate the properties of window.location, one of the members is "toString()". It isn't listed for other objects like window.history. I assume this is related to the fact that window.location overrides toString().
|
||
Comment 1•19 years ago
|
||
How is this a bug?
|
Reporter | |
Comment 2•19 years ago
|
||
Brendan says .toString() should not be enumerable, for consistency.
|
Assignee | |
Comment 3•19 years ago
|
||
This makes xpconnect always treat toString and toSource as non-enumerable, even when they're a method of an interface.
|
|
Assignee | |
Updated•19 years ago
|
|
||
Comment 4•19 years ago
|
||
Comment on attachment 189240 [details] [diff] [review] v1 r=jst
Attachment #189240 -
Flags: review?(jst) → review+
|
||
Comment 5•19 years ago
|
||
Comment on attachment 189240 [details] [diff] [review] v1 This is ok for 1.8b4. /be
Attachment #189240 -
Flags: approval1.8b4+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #189240 -
Flags: superreview?(brendan)
|
|
||
Comment 6•19 years ago
|
||
Comment on attachment 189240 [details] [diff] [review] v1 Forgot to mark my sr+ earlier! /be
Attachment #189240 -
Flags: superreview?(brendan) → superreview+
|
|
||
Updated•19 years ago
|
Flags: blocking1.8b4+
|
|
Assignee | |
Updated•19 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•