Closed Bug 301052 Opened 19 years ago Closed 19 years ago

Nullplugin doesn't open window anymore

Categories

(Core Graveyard :: Plug-ins, defect, P1)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8beta5

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

(Keywords: fixed1.8, regression)

Attachments

(1 file)

steps to reproduce:
1. load http://biesi.damowmow.com/object/embed_incomplete_and_invalid/033.html
2. get dialog asking for a plugin
3. click OK

expected results:
webpage should open in a new window

actual results:
dialog disappears, nothing else happens

Is this due to the new plugin popup blocking?

Seen in SeaMonkey, linux, gtk2, checkout finish: Don Jul 7 18:05:39 CEST 2005

*** This bug has been marked as a duplicate of 306177 ***
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → DUPLICATE
oops, mac has its own implementation
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Yeah, I think each platform has its own.
Assignee: nobody → cbiesinger
Status: REOPENED → NEW
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
Attached patch patchSplinter Review
Attachment #194927 - Flags: superreview?(jst)
Attachment #194927 - Flags: review?(jst)
Attachment #194927 - Flags: superreview?(jst)
Attachment #194927 - Flags: superreview+
Attachment #194927 - Flags: review?(jst)
Attachment #194927 - Flags: review+
fixed on trunk
Checking in modules/plugin/samples/default/unix/npunix.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/npunix.c,v  <--  npunix.c
new revision: 1.10; previous revision: 1.9
done
Checking in modules/plugin/samples/default/unix/nullplugin.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/nullplugin.c,v  <-- 
nullplugin.c
new revision: 1.17; previous revision: 1.16
done
Checking in modules/plugin/samples/unixprinting/npunix.c;
/cvsroot/mozilla/modules/plugin/samples/unixprinting/npunix.c,v  <--  npunix.c
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Closed: 19 years ago19 years ago
Resolution: --- → FIXED
Comment on attachment 194927 [details] [diff] [review]
patch

this makes the nullplugin work again in applications that use it; does not
affect firefox and is low risk.
Attachment #194927 - Flags: approval1.8b5?
Attachment #194927 - Flags: approval1.8b5? → approval1.8b5+
checked in to MOZILLA_1_8_BRANCH for 1.8b5

Checking in modules/plugin/samples/default/unix/npunix.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/npunix.c,v  <--  npunix.c
new revision: 1.9.44.1; previous revision: 1.9
done
Checking in modules/plugin/samples/default/unix/nullplugin.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/nullplugin.c,v  <-- 
nullplugin.c
new revision: 1.16.12.1; previous revision: 1.16
done
Checking in modules/plugin/samples/unixprinting/npunix.c;
/cvsroot/mozilla/modules/plugin/samples/unixprinting/npunix.c,v  <--  npunix.c
new revision: 1.1.28.1; previous revision: 1.1
done
Keywords: fixed1.8
Target Milestone: mozilla1.9alpha → mozilla1.8beta5
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: