301065 - TB crashes on close when using TB Progress History extension [@ nsObsoleteACStringThunk::`vftable' 3d5daa74]

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Frank]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050530 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050530 Firefox/1.0+

TB will always crash upon close if TB Progress History Extension is running
Get the extension here http://www.supportware.net/mozilla/StatusMsgHistory.xpi

The extension replaces TBs own nsIMsgStatusFeedback component with its own.. 
The crash used to occur immediately after polling a pop server then selecting
any message.  It crashes TB now only on close because the extension now stores
nsIRequests that come through on the onProgress function of the (new)
nsIProgressEventSink interface.  

It seems that the crasher *could* be due to one line in nsPop3Protocol.cpp
http://lxr.mozilla.org/seamonkey/source/mailnews/local/src/nsPop3Protocol.cpp#626

This line ( in the destructor of the class! ) causes the nsPop3Protocol.cpp to
make a call to the progressEventSink's OnProgress function  

Please see the last post in
http://forums.mozillazine.org/viewtopic.php?t=275186&highlight=statusmsghistory 

Is this  UpdateProgressPercent(0, 0); call even required ?

Reproducible: Always

Steps to Reproduce:
1. Start TB
2. Be sure to poll a pop server 
3. Close TB


Actual Results:  
Crashes TB

Expected Results:  
Not crash TB

talkback id TB7547514Q

Comment 1

[Frank]

link to talkback report

http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB7547514Q

Comment 2

[timeless]

talkback reports don't last forever, please either attach them or paste the
stacks to the bug.

Incident ID: 7547514
Stack Signature	nsObsoleteACStringThunk::`vftable' 3d5daa74
Product ID	ThunderbirdTrunk
Build ID	2005071304
Trigger Time	2005-07-16 17:56:24.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	xpcom_core.dll + (000469c2)
URL visited	
User Comments	Closing Thunderbird
Since Last Crash	2634 sec
Total Uptime	242145 sec
Trigger Reason	Access violation
Source File, Line No.	N/A
Stack Trace 	
nsObsoleteACStringThunk::`vftable'
DOMGCCallback 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/dom/src/base/nsJSEnvironment.cpp,
line 2087]
js_ForceGC 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/js/src/jsgc.c,
line 1502]
nsObserverService::NotifyObservers 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/xpcom/ds/nsObserverService.cpp,
line 235]
NS_ShutdownXPCOM_P 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/xpcom/build/nsXPComInit.cpp,
line 764]
ScopedXPCOMStartup::~ScopedXPCOMStartup 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/toolkit/xre/nsAppRunner.cpp,
line 549]
main 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/mail/app/nsMailApp.cpp,
line 62]
kernel32.dll + 0x214c7 (0x77e814c7)

Comment 3

[Nickolay_Ponomarev]

darin or bienvenu: could you explain what's up with that UpdateProgressPercent
call in destructor. Is it really needed and if so, where can it be moved? Thanks.

timeless said the analysis was close to correct
"timelyx	that's exactly what's screwing up
 timelyx	or at least close enough to exactly"

Comment 4

[David :Bienvenu]

ok, we shouldn't need that call since we made the same call in the POP3_FREE state.

Comment 5

[David :Bienvenu]

Attachment: proposed fix

Comment 6

[David :Bienvenu]

thx for the explanation, timeless.

Comment 7

[Frank]

Thanks for the quick work on this guys.  

Hats off to ya