302097 - E4X: Function.prototype.toString incorrectly quotes {} attribute values

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Given the function:
function f(k) {
  return <xml k={k}/>;
}

f.toString() returns
function f(k) {
  return <xml k="{k}"/>
}

which is incorrect.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Once bug 301692 is checked in, I think I'll be able to fix this, also.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Don't quote every attribute

This simple (hah! A simple patch in the decompiler!) patch remembers whether
the attribute value wants to be quoted or not.

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 190606 [details] [diff] [review]
Don't quote every attribute

r+a=shaver.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.

Comment 5

[Bob Clary [:bc] (inactive)]

Checking in regress-302097.js;
/cvsroot/mozilla/js/tests/e4x/TypeConversion/regress-302097.js,v  <-- 
regress-302097.js
initial revision: 1.1

Comment 6

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20060818 windows/mac*/linux