302486 - Proxy (PAC) edit box plays games with URI fixup while you type

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[James Ross]

After reading a Hendrix comment
(http://groups-beta.google.com/group/netscape.public.beta.feedback/browse_thread/thread/fe9a13374814216e/a42ec67b5bd4783c#a42ec67b5bd4783c)
I went and tried the proxy/PAC URL box myself in trunk. Oh my was it broken!

It *seems* to be calling URI Fixup and /applying it/ for every character I type.
So I select the box and hit "f" to enter my nice file: URL, and it imediately
changes it to "http://f/". Evil.

This might be useful, and was obviously put in conciously, but doing it on every
character is wrong. I am putting this as major because normal people don't stand
a chance of /using/ this any more - I worked out how to enter a file URL,
millions wouldn't.

It would appear that onsynctopreference is calling it, but I am pretty sure it
shouldn't be doing anything like that while I edit it (at least not on Windows).

Comment 1

[Dave Townsend [:mossop]]

I have noticed that for some reason, in Firefox, the onsynctopreference is
called for every character that is typed into a text box. In Thunderbird
however, it is only called when focus moves away from the textbox.

Comment 2

[Tom Hessman]

I see this on Mac OS X too (2005-08-03).  I also noticed that it won't let me
delete the characters it automatically filled in until I exit the dialog and
come back in, which makes it even more annoying!

Comment 3

[Dave Townsend [:mossop]]

*** Bug 305024 has been marked as a duplicate of this bug. ***

Comment 4

[Dave Townsend [:mossop]]

*** Bug 306074 has been marked as a duplicate of this bug. ***

Comment 5

[Dave Townsend [:mossop]]

This really needs to be fixed for 1.5.

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Agreed.  We need this fixed.  Copying others who could help fix this.

Comment 7

[Mike Connor [:mconnor]]

Attachment: fun fun fun

So, onsynctopreference fires onchange, so we can't use that.  Fortunately,
we're in a subdialog, so we can hackaround this by using beforeAccept to update
the field and the <preference/>

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 193959 [details] [diff] [review]
fun fun fun

r=vladimir

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 193959 [details] [diff] [review]
fun fun fun

a=caillon.  Thanks for the quick response.

Comment 10

[Mike Connor [:mconnor]]

fixed branch and trunk.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

(fwiw, not an issue in seamonkey, which does this in onblur)

Comment 12

[[e-mail]]

(In reply to comment #11)
>(fwiw, not an issue in seamonkey, which does this in onblur)
No, we use onchange, but we don't have onsynctopreference (instant-apply).

Comment 13

[Dave Townsend [:mossop]]

*** Bug 307435 has been marked as a duplicate of this bug. ***

Comment 14

[zug_treno]

*** Bug 317977 has been marked as a duplicate of this bug. ***

Comment 15

[benc]

V/fixed. 
FF 3.0.1/macos
I have been doing some feature testing and dogfood, and poking around the code as well.