304646 - nsPrintOptions::InitPrintSettingsFromPrefs shouldn't do NS_WARNING when prtName.IsEmpty()

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Bastiaan Jacques]

..because it is seems to be a normal occurrence. Also, as I (repeatedly) pointed
out in bug 303091, nsPrintOptions::SavePrintSettingsToPrefs() shouldn't write
the preferences when the printer name is empty. The code in
InitPrintSettingsFromPrefs() (which is functionally the same as before I
modified it) strenghtens my case.

Comment 1

[Bastiaan Jacques]

Attachment: patch

The NS_ENSURE_SUCCESS() in InitPrintSettingsFromPrefs will signal in OOM
situations.

Comment 2

[Bastiaan Jacques]

Comment on attachment 192687 [details] [diff] [review]
patch

..But another comment in the file counted against my case. Removing review
requsts pending further investigation.

Comment 3

[Bastiaan Jacques]

Attachment: try 2

I'm now of the opinion that the comment inside SavePrintSettingsToPrefs is
wrong. It makes sense to me when taking in mind how InitPrintSettingsFromPrefs
reads prefs without a printer name. This patch maintains the original
behaviour, changes the comments to make more sense and removes the NS_WARNING
as the previous patch did.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 194105 [details] [diff] [review]
try 2

sr=dmose

Comment 5

[timeless]

Comment on attachment 194105 [details] [diff] [review]
try 2

mozilla/gfx/src/nsPrintOptionsImpl.cpp	1.76

Comment 6

[Bastiaan Jacques]

Revision was 1.78.