305639 - [FIX]Transferring data from... infinitely in statusbar

Status: VERIFIED FIXED

(Core :: Networking, defect, P1)

Description

[Ria Klaassen (not reading all bugmail)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050823 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050823 Firefox/1.6a1

In trunk I see endless loading sites. 
The same sites load normally in branch.
There is no cache involved this time; it also happens if I visit the site for
the first time.

Reproducible: Always

Steps to Reproduce:
1. Go with a recent trunk build to https://bugzilla.mozilla.org/
2. Enter in the search box: bfcache
3. The page will load endlessly

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Confirming wtih both today's trunk SeaMonkey and Firefox builds on Windows XP.

bz, any ideas?

Comment 2

[Ria Klaassen (not reading all bugmail)]

This is a regression between 2005082210 and 2005082222.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

For multipart requests, the document in the window can change without the
loadgroup being stopped, so we need to make sure to manually remove our
mOnloadBlocker from the loadgroup when we're being taken out of the window.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 193601 [details] [diff] [review]
Fix

r+sr=dbaron, after discussion with bz on IRC (essentially the loadgroup already
belongs to another document, so this won't synchronously fire onload on this
one)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-08-24-05 on Windows XP, SeaMonkey trunk.