307157 - Gaps on stretchy characters

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[rbs]

Some gaps occur on stretchy characters. There hit particlarly Linux, or newish
high resolution screens on Windows. I will attach a patch to mitigate these
pixel/roundoff issues. It does the trick for me on Windows on Linux.

Comment 1

[rbs]

Attachment: patch

Comment 2

[rbs]

Comment on attachment 194978 [details] [diff] [review]
patch

@@ -1602,7 +1603,9 @@
   // if we are not a largeop in display mode, return if size fits
-  if (targetSize <= 0 || (!largeop && IsSizeOK(charSize, targetSize,
aStretchHint))) {
+  if ((targetSize <= 0) || 
+      (!largeop && ((isVertical && charSize >= targetSize) ||
+		     IsSizeOK(charSize, targetSize, aStretchHint)))) {

Ops... that bit from bug 306004 crept in here. It is not relevant here.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You might want to add a comment that this is a bit of a hack and in the new Gfx
world maybe we can fix this "for real".

Comment 4

[rbs]

Attachment: gaps due to curved end points (screenshot without the patch)

It appeared from testing that some of the pieces been glued together have
curved end points (with the tip of the curves possibly rounded off). It is
likely that we will still have to jam these pieces to account for such curves.
That's why I used the non-fixed rulethickness (instead of a fixed amount of
pixels) to jam enough for the curves that are scaling.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

okay. yuck.

Comment 6

[rbs]

Checked in.

Comment 7

[rbs]

Comment on attachment 194978 [details] [diff] [review]
patch

A similar beautification as bug 306543, but this one is specific to stretchy
MathML characters.

Comment 8

[rbs]

Checked in the 1.8 branch.

Comment 9

[Boris Zbarsky [:bzbarsky]]

This checkin caused bug 321994

Comment 10

[rbs]

Apparently not. I have track that bug down to --enable-pango (unless this checkin awoke something else in pango. you never know...).