307643 - mac l10n repackaging broken on 1.8 branch

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Axel Hecht [:Pike]]

We don't have current mac builds, as the repackaging collapsed again.

MacOSX Darwin 7.9.0 maya Clbr Fx-Release didn't build for quite some time,
I guess the yellow on 
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8-l10n&hours=24&maxdate=1126210526&legend=0

broke it.

Comment 1

[Mark Mentovai]

Attachment: fix

In order to extract the license from the dmg, we:
 - unflatten it, putting the license in a resource fork
 - run DeRez, to slurp the license resources out
 - flatten it again, hopefully restoring the dmg to its original state

Read-only/read-write only applies to the filesystem within the dmg.  This (and
only this) part of the unpackaging deals with the file directly.  This process
should leave the "in" dmg in exactly the same state that it was discovered, and
I've never seen it ruin the file, but that's what's happening here.

So, we can change the process above to:
 - copy the "in" dmg to a temporary location
 - unflatten it, putting the license in a resource fork
 - run DeRez, to slurp the license resources out
 - remove the "in" dmg

Comment 2

[Mark Mentovai]

(In reply to comment #1)
>  - remove the "in" dmg

The temporary one, I mean.

Comment 3

[Mark Mentovai]

Checked in on the trunk.  Will hit the branch when it opens.  No official
localized Mac Firefox 1.5b1s, tough luck.

Note that trunk Firefox l10n repackaging is failing for a different reason: maya
is configured with --enable-official-branding and is looking for Firefox.app,
but atlantia is using generic branding, providing DeerPark.app.

Comment 4

[Mark Mentovai]

Checked in, branch.

Comment 5

[Chase Phillips]

We've got new Mac l10n builds in
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8-l10n/.
 Fix is verified.