Closed
Bug 307797
Opened 19 years ago
Closed 19 years ago
Regressions from bug 272702
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
10.42 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Known fallout includes: - Newlines in multiline scripts are no longer accounted for. - Userdefined tags _only_ go in the head now. I have fixes for both of those bugs and I've also fixed bug 190576 while here.
|
Assignee | |
Comment 1•19 years ago
|
||
The fix for the userdefined tag problem was that I was basically testing if there had _ever_ been a <head> tag instead of finding if that head section was still open.
Attachment #195472 -
Flags: superreview?(jst)
Attachment #195472 -
Flags: review?(jst)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 195472 [details] [diff] [review] Get newline counting right - In CNavDTD::BuildModel(): // So we need to make sure the parser is in a state where it can be // interrupted. // The mParser->CanInterrupt will return TRUE if BuildModel was called // from a place in the parser where it prepared to handle a return value of // NS_ERROR_HTMLPARSER_INTERRUPTED. // If the parser has mPrevContext then it may be processing // Script so we should not allow it to be interrupted. // We also need to make sure that an interruption does not override // a request to block the parser. if (mParser->CanInterrupt() && - !mParser->PeekContext()->mPrevContext && + !IsParserInDocWrite() && NS_SUCCEEDED(result)) { Fix the above comment too. r+sr=jst
Attachment #195472 -
Flags: superreview?(jst)
Attachment #195472 -
Flags: superreview+
Attachment #195472 -
Flags: review?(jst)
Attachment #195472 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•