319528 - File->Quit, "Confirm close" shows in other workspace

Status: NEW

(Firefox :: Tabbed Browser, defect)

Description

[Ginn Chen]

A customer complained about this.

1)Open a firefox window with 2 tabs in Workspace 1
2)Open a new firefox window in Workspace 2
3)Press Ctrl+Q in firefox in Workspace 2
4)Nothing happens in Workspace 2 (few people can notice that "Confirm close" is opened in Workspace 1)

Comment 1

[Ginn Chen]

Attachment: patch

It can bring "Confirm close" dialog to current workspace.
But the dialog says "You can about to close 2 open tabs", I think it's still some kind of confusing.
Any idea?

Comment 2

[Ginn Chen]

Change the summary, since Ctrl+Q is gone.

Comment 3

[Mike Connor [:mconnor]]

This seems like a strange hack.  I think I have a patch that addresses this better without mucking with focus.  Basically, it pops a dialog from the window that quit is called from, with something like "you are about to close 2 windows with 3 open tabs, do you wish to quit?"  Its a better and less-confusing dialog (if the dialog appears on the window with one tab, it doesn't make sense) and it would be called if you have seven windows instead of seven tabs.

Comment 4

[Ginn Chen]

Comment on attachment 205291 [details] [diff] [review]
patch

Agree

Comment 5

[Tracy Walker [:tracy]]

*** Bug 292342 has been marked as a duplicate of this bug. ***

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Actually, this is probably just us not setting the right transient hint on the window when we do the popup.  The window manager will switch workspaces for you if the hint is set right.

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

That came across wrong.  The window manager will switch the workspace the window is on (it will move it to the current workspace) if the hint is properly set.