322274 - native-theme GTK undetermined progressmeter oversteps its boundaries

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P2)

Description

[Vidar Haarr (not reading bugmail)]

The progress meter in the mail/news statusbar when downloading e-mail oversteps its boundaries by quite alot in 1.0b.

Running on GNOME 2.13 with gtk2-engines 2.7.x.

Screenshot coming up.

Comment 1

[Vidar Haarr (not reading bugmail)]

Attachment: progress meter screenshot

It oversteps both on the left and the right side, btw.

Comment 2

[Vidar Haarr (not reading bugmail)]

Requesting blocking-seamonkey1.0? since this looks really weird.

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

What theme are you using in that screenshot?

Comment 4

[Vidar Haarr (not reading bugmail)]

Seamonkey 1.0 beta, Classic XPFE theme and Clearlooks GTK theme.

Comment 5

[Andrew Schultz]

Does it happen with other gtk themes?
This is probably a XUL widget bug.

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

This doesn't seem common enough to block.

Comment 7

[Andrew Schultz]

Changing gtk theme didn't seem to have any effect on SeaMonkey's (gtk2 with classic theme) progress bar for me (not even a color change).

Comment 8

[Andrew Schultz]

hmm, other themes did change the progress meter, but none had behavior like the screenshot.  I have gtk2-engines 2.6.3

Comment 9

[Andrew Schultz]

I'm seeing this now with FC5 (gtk2 2.8)

Comment 10

[Andrew Schultz]

Progress meters don't work to well in standalone XUL, but this is sufficient to see this bug as chrome:

<!DOCTYPE window [ ]>
<window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
  <progressmeter mode="undetermined" value="0"/>
</window>

Comment 11

[Andrew Schultz]

actually, attachment 197827 [details] from bug 310417 exhibits this bug.  I was missing the stylesheet.

Comment 12

[Andrew Schultz]

*** Bug 331963 has been marked as a duplicate of this bug. ***

Comment 13

[Andrew Schultz]

see also https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186699

Comment 14

[Andrew Schultz]

*** Bug 342947 has been marked as a duplicate of this bug. ***

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Should this be pushed to widget:Gtk for issues in GTK native theme code?

I know I see this in the official Thunderbird 1.5.* build a lot; I don't think I've ever seen it in a build I compiled myself.  But I'm not sure if I ever tested the same things.

Comment 16

[Andrew Schultz]

I dumped this in XPToolkit as that seemed to be the most popular native theme component, although the bugs are spread out all over.

I do see this in my own builds.  You can test attachment 197827 [details] in a browser.

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ah, right.  So do I.

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: possible patch

This sorta works, although it doesn't look all that great when it hits the right edge.

Comment 19

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't understand how this works. Don't we need to pass in the correct widget rectangle to ensure that the theme draws correctly?

Is this even a bug on cairo? On cairo we don't trust the cliprect provided to the theme and force clipping by other means.

You could use gdk_rectangle_intersect here.

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Worksforme in cairo builds.