324832 - Downloaded *xpi langpackages from FTP cause error message upon startup

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

I downloaded the current set of langpacks from ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/1.5/linux-i686/xpi/

and placed them in the extensions/ subdir of my appdir (which happens to be /usr/lib/firefox-1.5/)

Upon startup, I receive the following dialog:
Firefox could not install this item because "install-73b..rdf" (provided by the item) is not well-formed or does not exist. Please contact the author about this problem.

where 73b (in install-73b..rdf) is always a different random string of characters.

The list of xpis I installed are:
ar.xpi  el.xpi     eu.xpi     hu.xpi  nb-NO.xpi  ro.xpi     tr.xpi
ca.xpi  en-GB.xpi  fi.xpi     it.xpi  nl.xpi     ru.xpi     zh-CN.xpi
cs.xpi  en-US.xpi  fr.xpi     ja.xpi  pl.xpi     sk.xpi     zh-TW.xpi
da.xpi  es-AR.xpi  ga-IE.xpi  ko.xpi  pt-BR.xpi  sl.xpi
de.xpi  es-ES.xpi  he.xpi     mk.xpi  sv-SE.xpi

Comment 1

[Benjamin Smedberg]

Aww fuckit: the install.rdf is invalid XML because the <?xml?> declaration is not the first thing in the file. Axel, can you look at see what include file or other nonsense is getting put before the XML declaration?

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Note the langpacks are temporarily available as I am installing them at: http://people.redhat.com/caillon/firefox-langpacks-20060125.tar.bz2

These are extracted and placed in the extensions/ directory during RPM installation.

The RPM spec commands are:

# Install langpacks
%{__mkdir_p} $RPM_BUILD_ROOT%{ffdir}/extensions
%{__tar} xjf %{SOURCE2}
%{__cp} firefox-langpacks/*.xpi $RPM_BUILD_ROOT%{ffdir}/extensions
%{__rm} -rf firefox-langpacks

which translates to:

mkdir -p /usr/lib/firefox-1.5/extensions
tar -xjf firefox-langpacks-20060125.tar.bz2
cp firefox-langpacks/*.xpi /usr/lib/firefox-1.5/extensions
rm -rf firefox-langpacks

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

In case it helps, looks like there are 3 of them without the xml line as the first thing in install.rdf.

% for i in `ls *.xpi`; do mkdir cur; cd cur; unzip ../$i; decl=`head -1 install.rdf`; echo "$i: $decl" >> ../installed; cd ..; rm -r cur; done
...
% cat installed
ar.xpi: <?xml version="1.0"?>
ca.xpi: <?xml version="1.0"?>
cs.xpi: <?xml version="1.0"?>
da.xpi: <?xml version="1.0"?>
de.xpi: <?xml version="1.0"?>
el.xpi: <?xml version="1.0"?>
en-GB.xpi: <?xml version="1.0"?>
en-US.xpi:
es-AR.xpi: <?xml version="1.0"?>
es-ES.xpi: <?xml version="1.0"?>
eu.xpi: <?xml version="1.0"?>
fi.xpi: <?xml version="1.0"?>
fr.xpi: <?xml version="1.0"?>
ga-IE.xpi: <?xml version="1.0"?>
he.xpi: <?xml version="1.0"?>
hu.xpi: <?xml version="1.0"?>
it.xpi: <?xml version="1.0"?>
ja.xpi: <?xml version="1.0"?>
ko.xpi:
mk.xpi:
nb-NO.xpi: <?xml version="1.0"?>
nl.xpi: <?xml version="1.0"?>
pl.xpi: <?xml version="1.0"?>
pt-BR.xpi: <?xml version="1.0"?>
ro.xpi: <?xml version="1.0"?>
ru.xpi: <?xml version="1.0"?>
sk.xpi: <?xml version="1.0"?>
sl.xpi: <?xml version="1.0"?>
sv-SE.xpi: <?xml version="1.0"?>
tr.xpi: <?xml version="1.0"?>
zh-CN.xpi: <?xml version="1.0"?>
zh-TW.xpi: <?xml version="1.0"?>

Comment 4

[Benjamin Smedberg]

The en-US.xpi is not a real langpack, please don't try to install it.

If you leave out ko and mk do the rest work correctly?

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

yes

Comment 6

[Axel Hecht [:Pike]]

*** Bug 324076 has been marked as a duplicate of this bug. ***

Comment 7

[Axel Hecht [:Pike]]

bug 324076 mentions line ending issues being the cause here.

Comment 8

[Alex Ihrig [:Thunderbird_Mail_DE]]

We should NOT ignore this problem until Fx/Tb 2.0. It would be a shame, not to be able to offer working lang packs for about a year (being realistic with release dates...).

Comment 9

[Benjamin Smedberg]

Alexander, since it's apparent that this only affects the ko and mk langpacks, are you willing to make a patch? We're not going to hold a release on this.

Comment 10

[Alex Ihrig [:Thunderbird_Mail_DE]]

Ups, sorry. I thought only ko.xpi and mk.xpi are correct.

Nevertheless, the german langpack de.xpi is not okay. It has 2 empty lines before the <xml...> tag. This occurs since Axel has checked in the patch to have 'em:id="[e-mail]"'. From this time on there are false line endings in mail/defines.inc.

I've checked in a correct defines.inc in trunk and Mozilla_1.8_Branch some times ago --> the build system produces correct/working de.xpi files.

Comment 11

[Axel Hecht [:Pike]]

Attachment: fix language pack defines on the trunk/1.8 branch

Comment 12

[Axel Hecht [:Pike]]

Attachment: fix language pack defines on the 1.8.0 branch

these patches fix the whitespace for the defines.inc for the de, mk and ko locales

IMHO, de should be fixed on trunk and 1.8, too, to have a trailing newline.

Comment 13

[Axel Hecht [:Pike]]

Alex, Channy, Damjan, I need your review for these patches, and once I land 
attachement 212491, confirmation of the fix for landing this on the 1.8.0
branch.

Comment 14

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #13)

I'm not sure, if your Patch will be working. I'm not sure about line endings (problem or not) and we are not able to see, if line endings will be correct in CVS before you've checked the patch in.

l10n/de could be fixed with my correct working (in trunk and 1.8_Branch) defines.inc

Comment 15

[A S Alam]

pa-IN.xpi is also showing same error during installation

source file "defines.inc" is here
http://lxr.mozilla.org/l10n/source/pa-IN/browser/defines.inc

can someone pls help me to solve problem for this locale?

Comment 16

[Alex Ihrig [:Thunderbird_Mail_DE]]

FYI:
Today I've checked in a Patch for 1.8.0_Branch _without_ approval:
http://bonsai-l10n.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_0_BRANCH&branchtype=match&dir=l10n%2Fde&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-03-15&maxdate=2006-03-16&cvsroot=%2Fl10n

There's only a risk for German Thunderbird XPIs. And this risk is NULL because of corrupt XPIs for more than 3 month now.

Comment 17

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #16)
First of all, I'd like to say sorry to Axel Hecht and all the other people heaving trouble or additional work because of my rude checkin into CVS.

As everyone can imagine, Axel wasn't amused about my checkin without approval in Mozilla_1.8.0_Branch. 

Nobody should follow my negative example (regardless of the correctness of my checked in patch). On the one hand we should be aware of the risk to loose CVS access, and on the other hand we should be aware of the risk for planned release dates.

Comment 18

[Damjan Georgievski]

(In reply to comment #13)
> Alex, Channy, Damjan, I need your review for these patches, and once I land 
> attachement 212491, confirmation of the fix for landing this on the 1.8.0
> branch.

Axel sorry, were you waiting for my reply? The patch looks ok for me.

Comment 19

[Alex Ihrig [:Thunderbird_Mail_DE]]

*** Bug 333104 has been marked as a duplicate of this bug. ***

Comment 20

[Roozbeh Pournader]

According to Behnam (CC-ed), the insertion of extra newlines may be because of a bug in translate-toolkit (http://translate.sourceforge.net/)

BTW, this bit us for two weeks when we were working on getting Firefox work for Persian.

Comment 21

[David Fraser]

Re comment 20: just wanting to check, have you filed a bug on the translate toolkit? bugs.wordforge.org
Excuse me if there already is one, but just wanted to make sure...

Comment 22

[Christopher Aillon (sabbatical, not receiving bugmail)]

So, this is getting worse, not better.  There were only 2 invalid langpacks, now there are 3.  pa-IN is now invalid.

The first line of install.rdf for it is:

<em:contributor>http://www.satluj.com</em:contributor>

We need a way to make sure that langpacks are either valid, or not shipped.

Comment 23

[Axel Hecht [:Pike]]

*** Bug 323876 has been marked as a duplicate of this bug. ***

Comment 24

[Channy Yun [:channy]]

(In reply to comment #13)
> Alex, Channy, Damjan, I need your review for these patches, and once I land 
> attachement 212491, confirmation of the fix for landing this on the 1.8.0
> branch.
> 

Axel, sorry my miss for this message. It's okay to delete final blank line on mail/default.inc. It's very strange to use mail/default.inc to make firefox's install.rdf.

Comment 25

[Axel Hecht [:Pike]]

Actually, it's that the browser/defines.inc just has the same bug in korean as the mail/defines.inc. Please fix this on the trunk and on the 1.8 branch? I'm not exactly sure if we would want a patch for the 1.8.0 branch, but you could create one for both mail and browser and request approval1.8.0.6, then we'll evaluate that for the next engineering cycle on the 1.8.0 branch.

Comment 26

[Channy Yun [:channy]]

Axel, I fixed 1.8 branch for both define.inc. https://bugzilla.mozilla.org/show_bug.cgi?id=345800 and will be fixed 1.8 trunk. 

I think fix this problem in 1.8.0.6. Because someone fails to install korean language pack in en-US build. It's somehow critical for future windows 98 or 95 users. Do I open new bug or attach my patch in this bug?

Comment 27

[Damjan Georgievski]

It seems there's been missunderstanding about whos doing what... I thought Axel would patch the problematic files.

I've fixed the mail/defines.inc and browser/defines.inc in MOZILLA_1_8_BRANCH (aka Fx/Tb 2.0).

How do I proceed with MOZILLA_1_8_0_BRANCH (aka Fx/Tb 1.5.0.x)?? 
The choice seems to be:
- I open a separate bug with patches, requesting approval 1.5.0.6?
- Axel maybe you could just patch the files?
- something else ?!???
- do nothing :)

Comment 28

[Axel Hecht [:Pike]]

(In reply to comment #27)
> How do I proceed with MOZILLA_1_8_0_BRANCH (aka Fx/Tb 1.5.0.x)?? 
> The choice seems to be:
> - I open a separate bug with patches, requesting approval 1.5.0.6?
> - Axel maybe you could just patch the files?
> - something else ?!???
> - do nothing :)

Best thing is to attach a patch here and ask for approval1.5.0.6. My patch actually didn't catch all of the occurences, it seems.

Comment 29

[Damjan Georgievski]

Attachment: fix language pack defines in l10n/mk on the 1.8.0 branch

Here's the patch that removes the lines at the end of l10n/mk/mail/defines.inc and l10n/mk/browser/defines.inc in MOZILLA_1_8_0_BRANCH

Comment 30

[Axel Hecht [:Pike]]

Comment on attachment 231099 [details] [diff] [review]
fix language pack defines in l10n/mk on the 1.8.0 branch

Giving this a technical review.
Note, we haven't start doing 1.8.0.6 approvals yet, so that part will still take a bit.

Comment 31

[Daniel Veditz [:dveditz]]

Comment on attachment 231099 [details] [diff] [review]
fix language pack defines in l10n/mk on the 1.8.0 branch

approved for 1.8.0 branch, a=dveditz for drivers

Comment 32

[Axel Hecht [:Pike]]

Attachement 231099 is checked in,
http://bonsai-l10n.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_0_BRANCH&branchtype=match&dir=l10n&file=&filetype=match&who=gdamjan%25on.net.mk&whotype=match&sortby=Date&hours=2&date=month&mindate=1131523200&maxdate=&cvsroot=%2Fl10n

Marking fixed, I think we got them all now.