329786 - Move url's to prefs

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Robert Accettura [:raccettura]]

Firefox typically keeps url's and such in prefs so that they can easily be changed for customization (CCK, localization, whatever) reasons.  

I think most of the stuff in globalstore.js belongs in prefs, especially anything related to the service.

IMHO it may be a good idea to standardize the url so that only the hostname and part of the path are customized.  For example:

String to save to pref: http://www.google.com/safebrowsing/

function returnUpdateURL(){
  return pref + "update?";
}
function returnLookupURL(){
  return pref + "lookup?";
}

if there say 3 pref namespaces understood by firefox:
extensions.google.safebrowsing.service1
extensions.google.safebrowsing.service2
extensions.google.safebrowsing.service3

It would let us preset up to 3 service providers.  It would be uber cool if they could all be used at the same time (if provided).

Comment 1

[Robert Accettura [:raccettura]]

cc->fritz, most likely asignee

Comment 2

[Tony Chang (Google)]

With integration with trunk/bonecho, the URLs are now in prefs. It don't (yet) support the multiple providers you mentioned.  I've opened bug 338598 for this.