Closed Bug 35046 Opened 24 years ago Closed 23 years ago

[RFE] Show download progress (%) in title when minimized

Categories

(Core Graveyard :: File Handling, enhancement, P3)

Product:
Core Graveyard
Component:
File Handling
Type:
enhancement

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: bugzilla, Assigned: law)

References

Details

(Keywords: helpwanted)

Attachments

(2 files)

Diff to change title of download to fx "35% Completed"
2.49 KB, patch
Details | Diff | Splinter Review
Similar to the previous patch, but only showing "% complete" when the window is not focussed, and applying to both download windows
7.02 KB, patch
Details | Diff | Splinter Review 
The download progress percentage should be displayed in the menubar of the 
Progress Window, if not at all times then at least when it's minimized 
(assuming a minimize button is coming).  This is a nice feature of IE that 
allows you to see how far along a download is without having to bring the 
progress window to focus.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: [RFE] Show download progress (%) in menubar → [RFE] Show download progress (%) in title bar
I think you mean the title bar, not the menu bar ... The progress window doesn't 
(or shouldn't) have a menu bar. Resummarizing.

This is a good idea, actually. Even better would be to show the progress by 
coloring in the window's icon -- that way you wouldn't even need the space 
required to show a percentage figure (in the Windows taskbar, etc); all you'd 
need is the icon square.
Yep, I did mean titlebar.  Not quite sure what I was thinkin that day when I 
said menubar, thanks for fixing.
mpt - i submitted that icon thing as bug 36776.  i think both should happen 
(title and icon).
Should only happen when the window is minimized/window-shaded, otherwise the 
dialog would be being impolite by telling you everything multiple times.
Keywords: 4xp
Summary: [RFE] Show download progress (%) in title bar → [RFE] Show download progress (%) in title when minimized
I personally find it annoying that I must take an extra action (minimize) in 
order to make IE's download progress to show in the taskbar.  That, and the 
fact that IE waits until the next percentage mark to actually put the percent 
in the title.

Is there a way to make the percent always show in the taskbar without making 
the dialog say the percent twice?
This is up to XPApps.
Assignee: evaughan → don
Component: Progress Window → XPApps
Target Milestone: --- → Future
*** Bug 41898 has been marked as a duplicate of this bug. ***
Henrik, the patch looks like it will show the % in the titlebar at all times, 
not just when minimized (as this bug says).  reassigning to you
Assignee: don → gemal
Keywords: patch
I know...:) I'm not sure how to make it appear only when minized.

Is it so bad that it also shows in the title when "maximized"? Need feedback....
I'll look into making it show when minimized only.  sounds like we just need to 
get the window state.  but yeah, I don't think it should be shown when the 
window is in the restored state, because then we're telling the user twice...
Blake Ross, since you are the one with inside knowledge into window states, I've 
reassigned this bug to you...
Assignee: gemal → BlakeR1234
Status: NEW → ASSIGNED
Component: XP Apps → XP Apps: GUI Features
Target Milestone: Future → M20
blake, i understand that you've got bunches of other bugs/testing to do (oh, 
yeah, and a life outside mozilla ;), so i've added helpwanted to this bug in 
case you cannot get to it. otherwise, feel free to remove the kw if you do think 
you can fix it in time for 6.0/1.0. thx!
Keywords: patch → helpwanted
*** Bug 49287 has been marked as a duplicate of this bug. ***
Priority: P3 → P2
Target Milestone: M20 → mozilla0.9
Priority: P2 → P3
Target Milestone: mozilla0.9 → mozilla1.0
This bug depends on bug 26029 which is about being able to minimize the download
progress save file dialog.
Depends on: 26029
I like what IE does: it shows the download progress in the task bar even when 
the dialog box is not minimized. Bug 49287 also doesn't mention minimizing the 
dialog box, and if this bug is a duplicate of that one, then it doesn't depend 
on Bug 26029.
No longer depends on: 26029
Depends on: 26029
reassigning to ben for now
Assignee: blakeross → ben
Status: ASSIGNED → NEW
nav triage team: this is a nice to have for nsbeta1
Keywords: nsbeta1
I have a patch which only displays the % completed in the titlebar when the 
window is not focussed, is that OK?
if you have such a patch, I hope it's using standard string substitution (which 
uses %s and a predefined function).  more info is available on irc.  patches 
are always welcome, please attach.
Assignee: ben → matthew
timeless: I can only find usage of the %s and standard substitution when using 
a string bundle created from a properties file.

Why are there two download windows? You get one window if you right click on a 
link and choose Save Link, and another if you do a left click and then choose 
Save As (instead of Open With).
*** Bug 72631 has been marked as a duplicate of this bug. ***
if we have and icon that changes state based on the completion - i suggest an
icon with at least 10 horizontal bars (10% to 100%), that change colors (green:
10-40%, yellow: 50-70%, red: 80-100%) as the download completes (see GetRight
taskbar icon).

Of course, since with multiple windows open, the taskbar buttons can get a bit
small, so the percentage complete (e.g. 36%) should be on the *left*!

The filename should be to the right of the percent complete.

Hovering over a download window in the taskbar shoul yield a tooltip
with the full path and filename, and filesize (if possible). ;)

I fully agree that the percentage should be displayed also when the window is
not minimized but not *focused*, since the download window could be behind other
windows (who's going to stop surfing during a download?). ;)
Henrik, you can fix with your patch 2 bug. This one and bug 72982
Peter, changing icon state to reflect download progress is bug 36776.

Most people seem to think that the %age should be shown in the window at all 
times (eg bug 72982). I find the argument that we should not duplicate 
information unconvincing, when we can (for example) access the bookmarks from 
up to four different locations. I think we should go for Henrik's original 
patch here.
To maintain visual consistency, we definetely should show the percentage
complete in the title (minimized, focused or not) at *ALL* times.

Not only is this info useful, but but it could confuse the user if sometimes the
title shows this info and sometimes it doesn't.

The percentage complete is unobtrusive (takes up *very* little space), and it
provides useful info (regardless of window state).
I personally think that the percentage should always be displayed.

This is one thing that annoys me in Netscape as well as Internet Explorer,
because I usually forget to minimize the window. Even if I minimize it, it's not
updated until 1 more % of the data is received.

So it would be nice if Mozilla would always display it.
It doesn't take much space, and implementation is easier, I suppose. Even though
there's already a patch for it.
cc'ing to self as a matter of interest.
Keywords: mozilla0.9.1
Bug 72982 covers showing the percentage in the Windows taskbar button, 
regardless of whether or not the window is minimized. Given that, there is no 
point in showing the percentage in the window title at all times -- the only 
time you'll see the window title is when the window is not minimized, in which 
case you can see the percentage in the window itself anyway.

So, the only use I can think of for this bug is for platforms which don't have 
a taskbar, i.e. Mac OS and (usually) Unix. In those cases again, it's only 
useful to show the percentage when you can't see the rest of the window -- i.e. 
when the window is window-shaded or minimized.

[James Ross, for future reference: CCing yourself with a comment causes more 
spam than CCing yourself without a comment. So if you have nothing to say, 
please don't say it.]
Showing the percentage all the time would be helpful when windows are tiled 
(partially covered) and not minimized. It seems to me that it would simplify 
(solve) the "show % in windows taskbar all the time" bug and be consistent in 
the titlebar. 
*** Bug 82870 has been marked as a duplicate of this bug. ***
MPT: I very strongly disagree with your remark that the percentage complete
should only be displayed when the window is minimized. Currently the titlebar of
the download progress window contains *NO* useful information, just the words
"Saving File." Even on platforms which don't have a taskbar, there are no
disadvantages to having the percentage displayed in the titlebar at all times,
and many disadvantages to not having it displayed at all times. It only takes as
many as five characters for the percentage (assuming the format "25%: Saving
File," and that the dialog disappears upon reaching 100%), so there is no
clutter issue, and there certainly isn't any problem with providing information
to a user twice. If you can't come up with a better reason why we shouldn't use
Henrik's patch than "telling you everything multiple times," please don't delay
the fixing of this bug with this nonsense.
Hey, Skewer, can I have some of the opposite of what you're having? I'm not 
delaying this bug. It's not assigned to me, it's not in my component, I'm not 
the relevant module owner, I'm not in a position to review the patch, and I 
haven't marked any dependencies.

On the contrary, I'm working with Doron on doing this as part of the fix for 
bug 67216. The plan is that on Windows the title for the progress window will 
be `27% of foo.zip', so as to be useful in the taskbar; and on Mac OS the title 
will be `Saving to “foo.zip”', so as to be consistent with move/copy windows in 
the Finder.
Blocks: 75364
Here's another thought:

On all platforms, especially MacOS which doesn't have the benefit of a taskbar,
references to download windows in the "Tasks" menu should include the percentage
completed (regardless of title/taskbar behavior). Since this menu is within
Mozilla's control, it could theoretically display some graphic representation of
the download progress (such as shading in behind the menu item). Anyone who is
more interested in that suggestion than I am is encouraged to start a new bug on
that; but display of the percentage in the Tasks menu is important.
It's a little late for m0.9.1. Changing keyword to 0.9.2.
Keywords: mozilla0.9.1 → mozilla0.9.2
*** Bug 90128 has been marked as a duplicate of this bug. ***
*** Bug 90950 has been marked as a duplicate of this bug. ***
Is there a reason attachment 26524 [details] [diff] [review] hasn't been checked in?
Keywords: review
*** Bug 99336 has been marked as a duplicate of this bug. ***
*** Bug 101303 has been marked as a duplicate of this bug. ***
*** Bug 102527 has been marked as a duplicate of this bug. ***
spam: over to File Handling. i have not changed the assigned developer [or the
other fields for that matter], so if anyone realizes that a bug should have a
more appropriate owner, go ahead and change it. :)
Component: XP Apps: GUI Features → File Handling
Blocks: 104166
*** Bug 112762 has been marked as a duplicate of this bug. ***
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
[SPAM]
Uh, this is a pretty asked-for bug (and likely an easy fix). Would it be
possible to add the KW "mozilla1.0" and re-upgrade the TM to mozilla1.0?
[/SPAM]
Agreed and done.
Keywords: mozilla1.0
Target Milestone: mozilla1.0.1 → mozilla1.0
*** Bug 117523 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla1.0 → mozilla1.0.1
Could we please get a decision on this?  Is the percentage shown in the titlebar
always, or only when minimized?
I would like it to always show and I don't understand why that's a problem.
I'm adding this feature in the course of overhauling the progress dialog for bug
27609, et al.  So don't invest too much time implementing it in obsolescent code.

The percentage is *always* shown in the title in the implementation I'm working
on, BTW.
*** Bug 123762 has been marked as a duplicate of this bug. ***
On Mac OS, change the window title while the download window is windowshaded. 
If you're always going to show percentages in the Tasks menu, then change the
window title to match what's in the Tasks menu when shaded, and change it back
when unshading.  For Mac OS X see Bug 124798: custom Dock icon.

Is "unshading" a real word?  Hmm.
See also bug 124670, add filename to download progress window title.
wfm, I guess law fixed this in 27609.  Reassigning to law so I can mark this bug
as fixed.
Assignee: matthew → law
Fixed for 0.9.9 if the target milestone in bug 27609 is correct.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.0.1 → mozilla0.9.9
*** Bug 124670 has been marked as a duplicate of this bug. ***
Verified WinXP
verified linux
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: