380846 - Make the build system friendlier for XULRunner apps and extensions

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

There are three significant obstacles that "third parties" (XULRunner apps and non-hosted extensions) face when trying to leverage the mozilla build system:

1) The build system refuses to progress beyond configure if it doesn't recognize the application specified in --enable-application.
2) The build system will only build an extension (or XULRunner app disguised as an extension) after building a recognized application (and XULRunner takes about at least half an hour to build on my new-ish machine). allmakefiles.sh hacks are also required.
3) Building a XULRunner app or an extension requires checking out all of XULRunner, even if you're using a prebuilt XULRunner SDK.

I should be able to tackle 1 and 2 in this bug, but I may split 3 off.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: WIP

bsmedberg, I was hoping you could look over these preliminary changes to make sure I'm not heading off in the wrong direction. Still to come:

1) Make confvars.sh files for the main apps.
2) Figure out the minimum set of makefiles that allmakefiles.sh should generate for an app that has a XULRunner SDK.
3) Figure out AC_DEFINE stuff.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Oh, and for reference, all the changes to make --with-libxul-sdk work were done in bug 299997.

Comment 3

[Benjamin Smedberg]

Comment on attachment 264969 [details] [diff] [review]
WIP

This looks great! Eventually of course I'd like to get all of our app/extensions using this infrastructure, but even just for new apps this is wonderful.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 264969 [details] [diff] [review]
WIP

>Index: extensions/build.mk
>+$(error You fogot to set --enable-extensions

Spelling nit: "forgot".

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Ok, here's a more complete patch. It makes confvars.sh files for all the major apps and extmakefiles.sh for all the extensions. The AC_DEFINE stuff is still in configure, but I think that might be ok.

I still need to figure out how to keep allmakefiles.sh from spitting out three tons of makefiles when --with-libxul-sdk is set.

Comment 6

[Benjamin Smedberg]

Comment on attachment 265644 [details] [diff] [review]
Patch, v1

I hate to do this to you, but can you unify the filename and variable name for extensions and applications? There are times when a single thing might be buildable as an extension or an application. Suggestions include MAKEFILES_local or even simply having makefiles.sh file call add_makefiles directly!

You need to have an Initial Developer block in all the new license headers. e.g. from http://www.mozilla.org/MPL/boilerplate-1.1/mpl-tri-license-sh

# The Initial Developer of the Original Code is
# ____________________________________________.

r=me with those changes

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v2 [checked in]

I went with calling add_makefiles directly.

Carrying forward r+, I'll check this in tomorrow.

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 265775 [details] [diff] [review]
Patch, v2 [checked in]

Landed this on trunk.

Comment 9

[Alfred Peng]

Attachment: Followup patch for Solaris

A bustage for Solaris: http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox-Ports.

The sh on Solaris doesn't support "source". Use "." instead.

Comment 10

[Alfred Peng]

Attachment: Patch v2 for Solaris [checked in]

Updated patch based on bent's comments. mrbkap helped to verify it on Ubuntu.

Comment 11

[[e-mail]]

Comment on attachment 265904 [details] [diff] [review]
Patch v2 for Solaris [checked in]

Thanks, this patch makes configure work with my ksh too.

Comment 12

[Laurent Jouanneau]

I have the same bug on kubuntu 6.10, and the patch for Solaris fix it.

Comment 13

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 265904 [details] [diff] [review]
Patch v2 for Solaris [checked in]

I landed this on trunk.

Comment 14

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Marking this fixed.

Followup work in bug 381900 and 381902.