Closed
Bug 417345
Opened 16 years ago
Closed 16 years ago
build broken on sparc
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: fta+bugzilla, Assigned: dwitte)
Details
Attachments
(2 files, 4 obsolete files)
2.33 KB,
patch
|
ted
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
320 bytes,
patch
|
ted
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
1.9b3 build is broken on sparc: g++-4.2 -o nsCookieService.o -c -fvisibility=hidden -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -DIMPL_NS_NET -I. -I. -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/pref -I../../../dist/include/storage -I../../../dist/include -I../../../dist/include/necko -I/usr/include/nspr -I/usr/include -I/usr/include -I../../../dist/sdk/include -fPIC -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-long-long -pedantic -g -fno-strict-aliasing -fshort-wchar -pthread -pipe -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -Werror -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsCookieService.pp nsCookieService.cpp cc1plus: warnings being treated as errors In file included from ../../../dist/include/xpcom/nsCOMArray.h:42, from nsCookieService.cpp:59: ../../../dist/include/xpcom/nsVoidArray.h: In member function 'void nsAutoVoidArray::ResetToAutoBuffer()': ../../../dist/include/xpcom/nsVoidArray.h:193: warning: cast from 'char*' to 'nsVoidArray::Impl*' increases required alignment of target type make[6]: *** [nsCookieService.o] Error 1 make[6]: Leaving directory `/build/buildd/xulrunner-1.9~b3/build-tree/mozilla/netwerk/cookie/src'
Assignee | ||
Comment 1•16 years ago
|
||
does this fix your build?
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → dwitte
Assignee | ||
Comment 2•16 years ago
|
||
note, dbaron has a patch in bug 409384 that should also fix this for nsVoidArray.
Comment 3•16 years ago
|
||
it does not fix it for me. I am building with gcc-4.3 build logs can be found http://sparc.koji.fedoraproject.org/koji/taskinfo?taskID=51185
Assignee | ||
Updated•16 years ago
|
Attachment #305601 -
Attachment is obsolete: true
Assignee | ||
Comment 4•16 years ago
|
||
ok, i'm going to take another stab at a fix (for real, this time!). in the meantime, this isn't a cookie bug, -> core/xpcom
Assignee: dwitte → nobody
Component: Networking: Cookies → XPCOM
QA Contact: networking.cookies → xpcom
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → dwitte
Assignee | ||
Comment 5•16 years ago
|
||
turn off -Wcast-align on sparc. let it join ia64 in its uniqueness.
Attachment #309157 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 6•16 years ago
|
||
(i tried fixing nsTHashtable, but it's not possible - we know the casts are correct but there's no way of telling the compiler so, short of sprinkling __align() constructs. other option is to disable WARNINGS_AS_ERRORS for cookies on sparc, but this is a pretty pervasive warning and sparc is a long shot from tier 1.)
Updated•16 years ago
|
Attachment #309157 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 7•16 years ago
|
||
Comment on attachment 309157 [details] [diff] [review] v2 requesting approval for a trivial build fix on sparc.
Attachment #309157 -
Flags: approval1.9?
Comment 8•16 years ago
|
||
Comment on attachment 309157 [details] [diff] [review] v2 a1.9+=damons
Attachment #309157 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 9•16 years ago
|
||
Checking in configure.in; /cvsroot/mozilla/configure.in,v <-- configure.in new revision: 1.1955; previous revision: 1.1954 done please reopen if this doesn't fix things for you guys. ;)
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 10•16 years ago
|
||
the previous patch fixed 32bit sparc but not 64bit sparc the attached patch fixed that part of the build for me. I hit a different failure that i will open a new bug for
Comment 11•16 years ago
|
||
I am unable to reopen the bug please do so
Assignee | ||
Updated•16 years ago
|
Attachment #309348 -
Flags: review?(ted.mielczarek)
Comment 13•16 years ago
|
||
Comment on attachment 309348 [details] [diff] [review] Patch Fixing for sparc64 Could you just change this to a case statement at this point? It's starting to get ugly.
Attachment #309348 -
Flags: review?(ted.mielczarek) → review-
Assignee | ||
Comment 14•16 years ago
|
||
dennis, want to roll a new patch and request review from :luser?
Comment 15•16 years ago
|
||
Dan Can do
Comment 16•16 years ago
|
||
Attachment #309348 -
Attachment is obsolete: true
Updated•16 years ago
|
Attachment #310881 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 17•16 years ago
|
||
Comment on attachment 310881 [details] [diff] [review] rewritten patch using case statement >+ case "$CPU_ARCH" in >+ ia64 | sparc | sparc64) >+ # don't use -Wcast-align on ia64, sparc or sparc64, it's noisy on those platforms > _WARNINGS_CFLAGS="${_WARNINGS_CFLAGS} -Wcast-align" looks like you've got your sense mixed up... you want the _WARNINGS_CFLAGS bit to be in the * case, no? ;)
Attachment #310881 -
Flags: review?(ted.mielczarek) → review-
Comment 18•16 years ago
|
||
you were right. I was still building with the patch appalied. the new one is better
Attachment #310881 -
Attachment is obsolete: true
Attachment #310889 -
Flags: review?(ted.mielczarek)
Comment 19•16 years ago
|
||
it builds on sparc32 with the patch applied. testing sparc64 now.
Comment 20•16 years ago
|
||
The patch doesnt apply to current cvs checkouts due to adding to the if statement to handle the intel compiler. i refactored handing of sparc cpus to be the same as powerpc. ive built on sparc64 with the new patch applied.
Attachment #310889 -
Attachment is obsolete: true
Attachment #310968 -
Flags: review?(ted.mielczarek)
Attachment #310889 -
Flags: review?(ted.mielczarek)
Updated•16 years ago
|
Attachment #310968 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 21•16 years ago
|
||
Comment on attachment 310968 [details] [diff] [review] make sparc same as ppc trivial build fix for sparc64.
Attachment #310968 -
Flags: approval1.9?
Comment 22•16 years ago
|
||
Comment on attachment 310968 [details] [diff] [review] make sparc same as ppc a=beltzner
Attachment #310968 -
Flags: approval1.9? → approval1.9+
Updated•16 years ago
|
Keywords: checkin-needed
Comment 23•16 years ago
|
||
Checking in configure.in; /cvsroot/mozilla/configure.in,v <-- configure.in new revision: 1.1969; previous revision: 1.1968 done
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
You need to log in
before you can comment on or make changes to this bug.
Description
•