Closed Bug 418775 Opened 16 years ago Closed 16 years ago

ubuntu configure bustage.

Categories

(Firefox Build System :: General, defect)

All
Windows Mobile 6 Standard
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

We are getting errors using configure on unbuntu:

/home/dougt/builds/moz1.9/mozilla/configure: 1205: Syntax error: Bad substitution

The problem is sh verses bash.


i removed this from configure.in and things are happy again.


Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/configure.in,v
retrieving revision 1.1934
diff -u -r1.1934 configure.in
--- configure.in    20 Feb 2008 22:38:25 -0000  1.1934
+++ configure.in    21 Feb 2008 04:52:30 -0000
@@ -219,22 +219,10 @@
     ac_exeext=.exe

     echo -n "#define TOPSRCDIR \"" > $srcdir/build/wince/tools/topsrcdir.h
-    MINGW32=""
-    case "$host_os" in
-    *mingw* )
-       MINGW32="MINGW32=1"
-   #  MingW path mangling /c/blah -> c:/blah
-   echo -n ${_topsrcdir:1:1}:${_topsrcdir:2} >> $srcdir/build/wince/tools/topsrcdir.h;;
-    *cygwin* )
-
-       echo -n ${_topsrcdir:10:1}:${_topsrcdir:11} >> $srcdir/build/wince/tools/topsrcdir.h;;
-    * )
-
-       echo -n ${_topsrcdir} >> $srcdir/build/wince/tools/topsrcdir.h;;
-    esac
+       echo -n ${_topsrcdir} >> $srcdir/build/wince/tools/topsrcdir.h;;
     echo -n \" >> $srcdir/build/wince/tools/topsrcdir.h

-    make $MINGW32 -C  $srcdir/build/wince/tools
+    make -C $srcdir/build/wince/tools
     echo -----------------------------------------------------------------------------
     ;;
 esac


Going to leave open until we have a real fix.
Summary: unbuntu configure bustage. → ubuntu configure bustage.
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1936; previous revision: 1.1935
done
Attached patch patch v.1Splinter Review
Attachment #304751 - Flags: review?(benjamin)
Attachment #304751 - Flags: review?(benjamin) → review+
Attachment #304751 - Flags: approval1.9?
Comment on attachment 304751 [details] [diff] [review]
patch v.1

a=beltzner for 1.9
Attachment #304751 - Flags: approval1.9? → approval1.9+
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1938; previous revision: 1.1937
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: